After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775040 - vaapidecode: implement negotiate() vmethod
vaapidecode: implement negotiate() vmethod
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-24 19:01 UTC by Víctor Manuel Jáquez Leal
Modified: 2016-12-14 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapidecode: implement negotiate() vmethod (2.40 KB, patch)
2016-11-24 19:01 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2016-11-24 19:01:25 UTC 
Instead of decorating the negotiate() method, let us override it,
so the stream is locked while called.
Comment 1 Víctor Manuel Jáquez Leal 2016-11-24 19:01:29 UTC 
Created attachment 340705 [details] [review]
vaapidecode: implement negotiate() vmethod
Comment 2 Víctor Manuel Jáquez Leal 2016-12-01 11:58:50 UTC 
Comment on attachment 340705 [details] [review]
vaapidecode: implement negotiate() vmethod

commit 3285121181295c544480fc6ba756845b16285d30
Author: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Date:   Mon Nov 21 18:25:18 2016 +0100

    vaapidecode: implement negotiate() vmethod

    Instead of decorating the negotiate() method, let us override it,
    so the stream is locked while called.

    https://bugzilla.gnome.org/show_bug.cgi?id=775040
Comment 3 Víctor Manuel Jáquez Leal 2016-12-13 12:49:08 UTC 
I have seen error logs since this commit. I think we should revert it.
Comment 4 Víctor Manuel Jáquez Leal 2016-12-14 15:25:57 UTC 
commit daed911caf4bbeee35273e78ebe029a03cf645b9
Author: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Date:   Fri Dec 9 17:56:02 2016 +0100

    vaapidecode: lock stream when setting caps

commit ba49dc9dd77e858946fd2ad277117abcc8e36ad9
Author: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Date:   Fri Dec 9 17:42:42 2016 +0100

    Revert "vaapidecode: implement negotiate() vmethod"

    This reverts commit 3285121181295c544480fc6ba756845b16285d30.

    videodecode's negotiate() vmethod is also called when events arrive,
    but this would mean that the proper configuration of sink pad might
    not be complete, thus we should not update the src pad.

    Let's keep the old non-vmethod negotitate().