Created attachment 340704 [details] [review]
Build: Add wayland to GSKs dependencies

gskrenderer.c includes gdk/wayland/gdkwayland.h and as a consequence
we need to be able to locate wayland's headers in case they are not
in standard location.

Review of attachment 340704 [details] [review]:

I'm puzzled as to how this should work.

Both libgdk and libgsk are private, non-installed libraries, and the header in question comes from the source/build directory, not from pkg-config. I don't understand why adding Wayland to the private requirements is going to do any good.

(In reply to Emmanuele Bassi (:ebassi) from comment #2)
> Review of attachment 340704 [details] [review] [review]:
> 
> I'm puzzled as to how this should work.
> 
> Both libgdk and libgsk are private, non-installed libraries, and the header
> in question comes from the source/build directory, not from pkg-config. I
> don't understand why adding Wayland to the private requirements is going to
> do any good.

yes but the header from our source direcory includes wayland-client.h - and this needs to be found using pkg-config

For reference, the build fails as follows if wayland has the header in non-default locations:

>[   95s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/gtk+-3.89.1/gsk'
>[   95s]   CC       libgsk_4_la-gskrenderer.lo
>[   95s]   CC       libgsk_4_la-gskrendernode.lo
>[   95s]   CC       libgsk_4_la-gskrendernodeiter.lo
>[   95s]   CC       libgsk_4_la-gsktexture.lo
>[   95s] In file included from ../gdk/wayland/gdkwayland.h:32:0,
>[   95s]                  from gskrenderer.c:57:
>[   95s] ../gdk/wayland/gdkwaylanddevice.h:27:28: fatal error: wayland-client.h: No such file or directory
>[   95s]  #include <wayland-client.h>
>[   95s]                             ^
>[   95s] compilation terminated.

Ah, of course.

Yes, then adding it to GSK_DEPS_PRIVATE is fine.

Review of attachment 340704 [details] [review]:

ACK-by: me.

Comment on attachment 340704 [details] [review]
Build: Add wayland to GSKs dependencies

pushed as commit cae8fc