After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774957 - websocket-connection: avoid sending data if we are closing the connection
websocket-connection: avoid sending data if we are closing the connection
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: API
unspecified
Other All
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
: 774956 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-11-23 19:09 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2016-12-03 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
websocket-connection: avoid sending data if we are closing the connection (1.72 KB, patch)
2016-11-23 19:09 UTC, Ignacio Casal Quinteiro (nacho)
committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2016-11-23 19:09:49 UTC
We cannot trust the client to be nice and stop sending data when
we are closing. If we receive a ping when closing the connection
we need to avoid trying to send data after that.

Change the code to be more robust and to not try to write in the socket
if we are in the closed state.

This fixes an assertion on the test 3.2 of autobahn:
See https://github.com/crossbario/autobahn-testsuite
Comment 1 Ignacio Casal Quinteiro (nacho) 2016-11-23 19:09:57 UTC
Created attachment 340635 [details] [review]
websocket-connection: avoid sending data if we are closing the connection
Comment 2 Ignacio Casal Quinteiro (nacho) 2016-11-23 19:10:42 UTC
meh, no idea why it got duplicated.

*** This bug has been marked as a duplicate of bug 774956 ***
Comment 3 Ignacio Casal Quinteiro (nacho) 2016-11-23 19:13:10 UTC
*** Bug 774956 has been marked as a duplicate of this bug. ***
Comment 4 Dan Winship 2016-12-03 14:58:29 UTC
Attachment 340635 [details] pushed as 3212d89 - websocket-connection: avoid sending data if we are closing the connection