After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774939 - GtkLabelAccessible: Initialize link before setting parent
GtkLabelAccessible: Initialize link before setting parent
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-11-23 16:43 UTC by Florian Müllner
Modified: 2016-11-24 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkLabelAccessible: Initialize link before setting parent (1.16 KB, patch)
2016-11-23 16:43 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-11-23 16:43:36 UTC 
See patch.

This fixes a segfault with current at-spi2-atk when a label contains a link.
Comment 1 Florian Müllner 2016-11-23 16:43:41 UTC 
Created attachment 340618 [details] [review]
GtkLabelAccessible: Initialize link before setting parent

Since at-spi-atk commit 96621a5e95 fixed PropertyChange notifications
for AccessibleParent, setting the parent will result in a call to
ref_state_set() which assumes that the object is fully initialized.
Comment 2 Matthias Clasen 2016-11-23 17:30:56 UTC 
Review of attachment 340618 [details] [review]:

sure
Comment 3 Matthias Clasen 2016-11-24 00:01:05 UTC 
Attachment 340618 [details] pushed as 593b75f - GtkLabelAccessible: Initialize link before setting parent