After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774920 - msdk: add support for SEI Frame Packing Arrangement in h264 encoder
msdk: add support for SEI Frame Packing Arrangement in h264 encoder
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-23 14:13 UTC by Zack Snyder
Modified: 2017-11-20 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom (8.92 KB, patch)
2017-10-31 08:10 UTC, Sebastian Dröge (slomo)
none Details | Review
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom (8.97 KB, patch)
2017-10-31 09:15 UTC, Sebastian Dröge (slomo)
none Details | Review
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom (9.01 KB, patch)
2017-11-02 16:39 UTC, Sebastian Dröge (slomo)
none Details | Review
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom (9.20 KB, patch)
2017-11-07 16:29 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Zack Snyder 2016-11-23 14:13:02 UTC
Add support to write the Supplemental Enhancement Information (SEI) FPA (Frame Packing Arrangement) flag, which is used for 3D Video encoding.

At first, start with side-by-side and top-bottom.

Sebastian Dröge (slomo) already implemented this in an encoder.
Comment 1 Sebastian Dröge (slomo) 2016-11-23 14:58:10 UTC
Ideally this would be handled directly inside the encoder, that is, inside MSDK. If that is not possible, adding it at the GStreamer level is possible and not too hard, but rather ugly.
Comment 2 Sebastian Dröge (slomo) 2017-10-31 08:10:49 UTC
Created attachment 362602 [details] [review]
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom

Ideally this would be supported directly in the Intel MediaSDK but
that's not the case nowadays.
Comment 3 Sebastian Dröge (slomo) 2017-10-31 09:15:20 UTC
Created attachment 362605 [details] [review]
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom

Ideally this would be supported directly in the Intel MediaSDK but
that's not the case nowadays.
Comment 4 Tim-Philipp Müller 2017-10-31 09:22:59 UTC
Comment on attachment 362605 [details] [review]
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom

>+#define PROP_FRAME_PACKING_DEFAULT    -1

Niggle: this should be GST_VIDEO_MULTIVIEW_FRAME_PACKING_NONE I think?
Comment 5 Sebastian Dröge (slomo) 2017-11-02 16:39:56 UTC
Created attachment 362846 [details] [review]
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom

Ideally this would be supported directly in the Intel MediaSDK but
that's not the case nowadays.
Comment 6 Sebastian Dröge (slomo) 2017-11-07 16:29:07 UTC
Created attachment 363158 [details] [review]
msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom

Ideally this would be supported directly in the Intel MediaSDK but
that's not the case nowadays.
Comment 7 Sebastian Dröge (slomo) 2017-11-20 12:41:16 UTC
Attachment 363158 [details] pushed as 538aae2 - msdkh264enc: Implement frame-packing SEI insertion for side-by-side and top-bottom