After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774917 - [wayland] child subsurfaces need to be placed relative to their parent
[wayland] child subsurfaces need to be placed relative to their parent
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 774475
Blocks: 774546
 
 
Reported: 2016-11-23 13:55 UTC by Olivier Fourdan
Modified: 2016-11-24 08:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH master] wayland: Place subsurfaces relative to their parent (2.58 KB, patch)
2016-11-23 13:59 UTC, Olivier Fourdan
none Details | Review
[PATCH gtk-3-22] wayland: Place subsurfaces relative to their parent (2.58 KB, patch)
2016-11-23 14:00 UTC, Olivier Fourdan
none Details | Review
[PATCH master] wayland: Place subsurfaces relative to their parent (2.80 KB, patch)
2016-11-23 14:40 UTC, Olivier Fourdan
committed Details | Review
[PATCH gtk-3-22] wayland: Place subsurfaces relative to their parent (2.80 KB, patch)
2016-11-23 14:41 UTC, Olivier Fourdan
committed Details | Review

Description Olivier Fourdan 2016-11-23 13:55:08 UTC
Description:

Following bug 774475, subsurfaces can now be a child of another GdkWindow (other than root), therefore those need to be placed relative to their parent and not assume the abs_x_abs_y is always (0,0).
Comment 1 Olivier Fourdan 2016-11-23 13:59:43 UTC
Created attachment 340599 [details] [review]
[PATCH master] wayland: Place subsurfaces relative to their parent

Now that subsurfaces can be created as child of another GdkWindow (and
not just the root window), they must be placed according to the location
of their parent, i.e. the abs_x/abs_y must be updated and taken int
account when placing and moving subsurfaces under Wayland.
Comment 2 Olivier Fourdan 2016-11-23 14:00:31 UTC
Created attachment 340600 [details] [review]
[PATCH gtk-3-22] wayland: Place subsurfaces relative to their parent

Same for gtk-3-22
Comment 3 Olivier Fourdan 2016-11-23 14:40:51 UTC
Created attachment 340603 [details] [review]
[PATCH master] wayland: Place subsurfaces relative to their parent

v2: Keep abs_x/abs_y at (0,0) for toplevel subsurfaces for obvious backward compatibility with existing subsurfaces (i.e. those with parent == root, before bug 774475)
Comment 4 Olivier Fourdan 2016-11-23 14:41:36 UTC
Created attachment 340604 [details] [review]
[PATCH gtk-3-22] wayland: Place subsurfaces relative to their parent

v2 - Same as for master.
Comment 5 Matthias Clasen 2016-11-23 17:34:28 UTC
Review of attachment 340603 [details] [review]:

ok
Comment 6 Matthias Clasen 2016-11-23 17:35:57 UTC
Review of attachment 340604 [details] [review]:

ok
Comment 7 Olivier Fourdan 2016-11-24 08:34:50 UTC
Comment on attachment 340603 [details] [review]
[PATCH master] wayland: Place subsurfaces relative to their parent

attachment 340603 [details] [review] pushed to git master as commit 39200e7 - wayland: Place subsurfaces relative to their parent
Comment 8 Olivier Fourdan 2016-11-24 08:35:52 UTC
Comment on attachment 340604 [details] [review]
[PATCH gtk-3-22] wayland: Place subsurfaces relative to their parent

attachment 340604 [details] [review] pushed to branch gtk-3-22 as commit 6053036 - wayland: Place subsurfaces relative to their parent