After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774915 - [Wayland]: Destroying the parent of a subsurface causes _gdk_window_destroy_hierarchy: assertion failed
[Wayland]: Destroying the parent of a subsurface causes _gdk_window_destroy_h...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 775470 (view as bug list)
Depends on: 774475
Blocks: 774546
 
 
Reported: 2016-11-23 13:43 UTC by Olivier Fourdan
Modified: 2016-12-05 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH master] wayland: destroy subsurfaces along with parents (952 bytes, patch)
2016-11-23 13:51 UTC, Olivier Fourdan
committed Details | Review
[PATCH gtk-3-22] wayland: destroy subsurfaces along with parents (956 bytes, patch)
2016-11-23 13:52 UTC, Olivier Fourdan
committed Details | Review

Description Olivier Fourdan 2016-11-23 13:43:08 UTC
Description:

Following bug 774475 when one creates a subsurface as a child of a native window, destroying the parent window will cause an assertion failure:

Gdk:ERROR:/home/ofourdan/src/gnome/gtk+/gdk/gdkwindow.c:2116:_gdk_window_destroy_hierarchy: assertion failed: (window->native_children == NULL)
Aborted (core dumped)

Additional data:

Trivial patch to follow.
Comment 1 Olivier Fourdan 2016-11-23 13:51:36 UTC
Created attachment 340597 [details] [review]
[PATCH master] wayland: destroy subsurfaces along with parents

Wayland subsurfaces can have other native window parents, but those need
to be destroyed along with the rest of the window hierarchy otherwise
an assert() is reached.
Comment 2 Olivier Fourdan 2016-11-23 13:52:35 UTC
Created attachment 340598 [details] [review]
[PATCH gtk-3-22] wayland: destroy subsurfaces along with parents

Same for branch gtk-3-22
Comment 3 Olivier Fourdan 2016-12-01 14:32:24 UTC
*** Bug 775470 has been marked as a duplicate of this bug. ***
Comment 4 Jonas Ådahl 2016-12-05 02:46:30 UTC
Review of attachment 340598 [details] [review]:

Makes sense to me.
Comment 5 Jonas Ådahl 2016-12-05 02:46:35 UTC
Review of attachment 340597 [details] [review]:

Makes sense to me.
Comment 6 Olivier Fourdan 2016-12-05 10:08:18 UTC
Comment on attachment 340597 [details] [review]
[PATCH master] wayland: destroy subsurfaces along with parents

attachment 340597 [details] [review] has been pushed to git master as commit f6b4477 - wayland: destroy subsurfaces along with parents
Comment 7 Olivier Fourdan 2016-12-05 10:08:58 UTC
Comment on attachment 340598 [details] [review]
[PATCH gtk-3-22] wayland: destroy subsurfaces along with parents

attachment 340598 [details] [review] has been pushed to branch gtk-3-22 as commit 7f39c7c - wayland: destroy subsurfaces along with parents
Comment 8 Olivier Fourdan 2016-12-05 10:09:32 UTC
Comment on attachment 340598 [details] [review]
[PATCH gtk-3-22] wayland: destroy subsurfaces along with parents

attachment 340598 [details] [review] [review] has been pushed to branch gtk-3-22 as commit 7f39c7c - wayland: destroy subsurfaces along with parents