After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774835 - Reduce the priority for the default GdTaggedEntryTag CSS
Reduce the priority for the default GdTaggedEntryTag CSS
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-11-22 11:28 UTC by Debarshi Ray
Modified: 2016-11-26 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tagged-entry: Reduce the priority of the default CSS (1022 bytes, patch)
2016-11-22 11:31 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2016-11-22 11:28:09 UTC
I think the priority should be lowered to GTK_STYLE_PROVIDER_PRIORITY_THEME, instead of the current GTK_STYLE_PROVIDER_PRIORITY_APPLICATION.

The problem is mostly historical.

Dark applications like gnome-photos have been using a different style class (say photos-entry-tag) and they use GTK_STYLE_PROVIDER_PRIORITY_APPLICATION load their CSS. Historically, the CSS was the same except the values of entry_tag_bg and entry_tag_fg. If the built-in light CSS uses the same priority, then it overwrites the colour definitions from the application.

Of course, the long term solution is to include the dark variant inside libgd itself, but it would be polite to let an application easily override the default.
Comment 1 Debarshi Ray 2016-11-22 11:31:21 UTC
Created attachment 340512 [details] [review]
tagged-entry: Reduce the priority of the default CSS
Comment 2 Cosimo Cecchi 2016-11-26 10:14:45 UTC
Review of attachment 340512 [details] [review]:

Thanks, feel free to push.
Comment 3 Debarshi Ray 2016-11-26 10:55:18 UTC
Comment on attachment 340512 [details] [review]
tagged-entry: Reduce the priority of the default CSS

Thanks for taking a look, Cosimo. Pushed to master.