After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774799 - Enable curl plugin
Enable curl plugin
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: cerbero
1.9.90
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 789109 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-11-21 16:53 UTC by Andrew Esh
Modified: 2018-11-03 10:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add curl library to support curlhttpsink build (1.58 KB, patch)
2016-11-21 16:55 UTC, Andrew Esh 		none Details | Review
Enable the curlhttpsink plugin (2.07 KB, patch)
2016-11-21 16:56 UTC, Andrew Esh 		none Details | Review
Fix TLS and prepend chunk length (9.35 KB, patch)
2016-11-21 17:15 UTC, Andrew Esh 		needs-work Details | Review

Description Andrew Esh 2016-11-21 16:53:15 UTC 
The curl plugin in gst-plugins-bad is normally shipped disabled. We have an application for it, so we enabled it and got it running. Adding patches here.
Comment 1 Andrew Esh 2016-11-21 16:54:13 UTC 
These patches are only of interest to those using the curlhttpsink plugin.
Comment 2 Andrew Esh 2016-11-21 16:55:32 UTC 
Created attachment 340454 [details] [review]
Add curl library to support curlhttpsink build

Not of interest unless enabling curlhttpsink.
Comment 3 Andrew Esh 2016-11-21 16:56:42 UTC 
Created attachment 340455 [details] [review]
Enable the curlhttpsink plugin

Enable curlhttpsink plugin, which depends on libcurl.
Comment 4 Andrew Esh 2016-11-21 17:15:04 UTC 
Created attachment 340460 [details] [review]
Fix TLS and prepend chunk length

This patch disables a lot of the other plugins, to focus on just using curlhttpsink. It also disables a few settings in the curlhttpsink support that get in the way of using TLS. Another addition is a prepended chunk length to the buffer being sent. We needed to do this since HTTPS with chunked encoding was not giving us the length of the block being sent, which we needed to deal with a blocking read interface.

This patch is probably only of interest to those who are enabling curlhttpsink, and who are looking for fixes to some of the problems we encountered.
Comment 5 Nicolas Dufresne (ndufresne) 2016-11-21 17:17:55 UTC 
Review of attachment 340460 [details] [review]:

Cerbero is definatly not the place to patch GStreamer Code. Propose patches against the right component if you encounter bugs or are missing features.
Comment 6 Sebastian Dröge (slomo) 2017-10-19 14:30:21 UTC 
*** Bug 789109 has been marked as a duplicate of this bug. ***
Comment 7 Sebastian Dröge (slomo) 2017-10-19 14:33:51 UTC 
Comment on attachment 340460 [details] [review]
Fix TLS and prepend chunk length

Yes, please put the changes to the code into a separate Bugzilla bug report and also split it up into individual, functional changes.
Comment 8 GStreamer system administrator 2018-11-03 10:21:35 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/cerbero/issues/39.