After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774796 - Fix librtmp tarball handling
Fix librtmp tarball handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
1.9.90
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-21 16:42 UTC by Andrew Esh
Modified: 2016-11-23 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Download the gz version of the tarball (936 bytes, patch)
2016-11-21 16:43 UTC, Andrew Esh
committed Details | Review
Rename the downloaded tarball (1.41 KB, patch)
2016-11-21 16:44 UTC, Andrew Esh
rejected Details | Review

Description Andrew Esh 2016-11-21 16:42:09 UTC
The librtmp distribution used by cerbero has problems constructing and naming their tarballs. These changes deal with downloading and renaming a tarball to capture the directory structure, and to refer to the tarball by the correct internal type.
Comment 1 Andrew Esh 2016-11-21 16:43:06 UTC
Created attachment 340450 [details] [review]
Download the gz version of the tarball
Comment 2 Andrew Esh 2016-11-21 16:44:23 UTC
Created attachment 340451 [details] [review]
Rename the downloaded tarball

The downloaded tarball is actually a gz file.
Comment 3 Sebastian Dröge (slomo) 2016-11-23 16:39:22 UTC
commit 6a939429f1ac7c9453a2287bdc792fa29aba5a5c
Author: Andrew Esh <andrew.esh@qterics.com>
Date:   Thu Oct 6 15:05:15 2016 -0500

    librtmp: Set rtmp tarball to gz, since that is what is actually downloaded.
    
    Rename tarball from bz2 to gz, since the bz2 one has the right directory structure, and is actually a gz anyway.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774796
Comment 4 Tim-Philipp Müller 2016-11-23 16:46:10 UTC
Uhm, this is on Edward's git, can we just get him to fix up the name perhaps? (Add a link with correct name or such)
Comment 5 Tim-Philipp Müller 2016-11-23 16:47:12 UTC
I meant Edward's home directory.
Comment 6 Tim-Philipp Müller 2016-11-23 18:02:03 UTC
commit ac3973db41d0021063c28585170aeec503271eca
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Wed Nov 23 18:00:30 2016 +0000

    recipes: rmtp: fix tarball type and location
    
    We have a location now for tarballs we mirror.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774796

commit f33033fe2a963132443bc2163050fde1ed48a4ec
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Wed Nov 23 17:58:08 2016 +0000

    Revert "librtmp: Set rtmp tarball to gz, since that is what is actually downloaded."
    
    This reverts commit 6a939429f1ac7c9453a2287bdc792fa29aba5a5c.
    
    We can just fix the tarball instead, we host it after all.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774796
Comment 7 Tim-Philipp Müller 2016-11-23 18:05:34 UTC
Comment on attachment 340451 [details] [review]
Rename the downloaded tarball

We control the tarball, we can fix/rename it as needed.
Comment 8 Tim-Philipp Müller 2016-11-23 18:14:47 UTC
sha256sum `pwd`/rtmpdump-2.4_p20131018.tar.gz ~bilboed/public_html/rtmp*
ad3777b08caaa05db949e1300d3bd6cb2f4b91bde323e25bd94cec7ff82b13ae  .../www/data/src/mirror/rtmpdump-2.4_p20131018.tar.gz
ad3777b08caaa05db949e1300d3bd6cb2f4b91bde323e25bd94cec7ff82b13ae  /home/bilboed/public_html/rtmpdump-2.4_p20131018.tar.bz2
57164e0c12f7cbff8e40b1e66cf6b889086387324851a115b427b8d2b3fff267  /home/bilboed/public_html/rtmpdump-2.4_p20131018.tar.gz