GNOME Bugzilla – Bug 774792
Add Android Marshmallow and Nougat
Last modified: 2016-11-22 05:47:20 UTC
Add new OS version selection to the Android support of cerbero.
Created attachment 340436 [details] [review] git format-patch of the addition
Review of attachment 340436 [details] [review]: ::: config/android.config @@ +97,3 @@ + v = '23' +elif target_distro_version == DistroVersion.ANDROID_NOUGAT: + v = '24' This looks incomplete: you also have to add these to enums.py
Created attachment 340442 [details] [review] Add marshmallow and nougat types
Created attachment 340445 [details] [review] Set ARM to Marshmallow Optional settings patch to update the ARM build to Marshmallow. Used and tested locally. The setting is not required, but should be updated.
Created attachment 340448 [details] [review] Set x86 to Nougat Local settings change, built and tested on x86 platform (Nexus Player, fugu). The change is not required, but should be updated.
Why the x86 and ARM changes? The problem with those is that the binaries would lose compatibility with all older Android versions, and we don't really need any new functionality from those NDKs at this point.
(In reply to Sebastian Dröge (slomo) from comment #6) > Why the x86 and ARM changes? The problem with those is that the binaries > would lose compatibility with all older Android versions, and we don't > really need any new functionality from those NDKs at this point. The platform settings can be rejected. I was just showing that I am using the settings introduced in the first two patches. There are certain boringssl dependencies under curlhttpsink that cause us not to be able to use older platform settings.
(In reply to Sebastian Dröge (slomo) from comment #2) > Review of attachment 340436 [details] [review] [review]: > > ::: config/android.config > @@ +97,3 @@ > + v = '23' > +elif target_distro_version == DistroVersion.ANDROID_NOUGAT: > + v = '24' > > This looks incomplete: you also have to add these to enums.py Yes sir, they were added. They are in the second patch.
We are still developing this product. The next release will probably be updated to use cerbero 1.10.x. I could redo the patches so the entire feature is in one patch, and made against 1.10. This applies to all my patches, not just this one. In other words, I plan to upgrade and maintain all the patches I have as I go forward, so if this first attempt is not "as expected", there will be opportunities for improvements later.
commit 772bf1b6d0bc6781438319fba3eaa16da3268f22 Author: Andrew Esh <andrew.esh@qterics.com> Date: Thu Oct 6 14:54:45 2016 -0500 android: Add Marshmallow and Nougat support https://bugzilla.gnome.org/show_bug.cgi?id=774792
Thanks! I've merged the two patches into one as they don't make much sense separately. The x86/ARM bits would be for a later time when we decide to drop support for old Android versions, which is not necessary as of today.