After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774776 - wrong install location for pam_gdm.so
wrong install location for pam_gdm.so
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.22.x
Other Linux
: Normal minor
: ---
Assigned To: GDM maintainers
GDM maintainers
https://bugs.gentoo.org/show_bug.cgi?...
Depends on:
Blocks:
 
 
Reported: 2016-11-21 08:02 UTC by Rémi Cardona
Modified: 2017-01-05 15:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add --with-pam-dir to ./configure (1.53 KB, patch)
2016-11-21 08:02 UTC, Rémi Cardona
none Details | Review
add --with-pam-mod-dir to ./configure (1.83 KB, patch)
2016-12-13 22:09 UTC, Rémi Cardona
committed Details | Review

Description Rémi Cardona 2016-11-21 08:02:31 UTC
Created attachment 340397 [details] [review]
add --with-pam-dir to ./configure

gdm installs pam_gdm.so in $(libdir)/security which expands to /usr/lib64/security on amd64 gentoo systems.

Unfortunately, our pam setup looks for pam modules in /lib64/security. autologin thus fails to work (non-autologin setup seem to be working fine).

The attached patch adds a --with-pam-dir option to ./configure to allow setting the directory, the default being the current $(libdir)/security.

NB: the patch is copy/pasted from gnome-keyring and I didn't do any sort of editing.  Let me know if you want me to change anything.
Comment 1 Ray Strode [halfline] 2016-11-21 12:09:59 UTC
i think we already have --with-pam-prefix ! Thanks for the patch though.
Comment 2 Rémi Cardona 2016-11-21 22:25:06 UTC
--with-pam-prefix only controls where the configuration files go (it defaults to /etc)

https://git.gnome.org/browse/gdm/tree/data/Makefile.am?h=3.22.1#n298

The issue here is the install location of the compiled pam module pam_gdm.so. May I get you to reconsider this patch ?

Thanks
Comment 3 Ray Strode [halfline] 2016-11-22 15:08:33 UTC
oh right, do you mind changing the existing option to be --with-pam-confdir and call this one --with-pam-libdir ? (or something like that?)  I basically don't want to have two similar sounding options that do different things since it can lead to confusion (cf comment 1 !)
Comment 4 Rémi Cardona 2016-12-13 22:09:15 UTC
Created attachment 341920 [details] [review]
add --with-pam-mod-dir to ./configure

The configure flag is now called --with-pam-mod-dir.  I've tweaked the indentation a bit and added some output in the summary at the end of configure.

Cheers
Comment 5 Ray Strode [halfline] 2017-01-05 15:19:45 UTC
thanks.