Bug 774732 – libsigc++-2.10.0 fails to disable benchmarks when configured with --disable-benchmarks

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 774732 - libsigc++-2.10.0 fails to disable benchmarks when configured with --disable-benchmarks


Summary:	libsigc++-2.10.0 fails to disable benchmarks when configured with --disable-b...


Status:	RESOLVED FIXED

Product:	libsigc++
Classification:	Bindings
Component:	build
Version:	2.10.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	libsigc++ maintainer(s)
QA Contact:	libsigc++ maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2016-11-19 22:58 UTC by kobboi
Modified:	2016-11-24 08:58 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Make --disable-benchmark work (1.45 KB, patch) 2016-11-19 22:58 UTC, kobboi	committed	Details \| Review

Description kobboi 2016-11-19 22:58:46 UTC

Created attachment 340330 [details] [review]
Make --disable-benchmark work

Currently, when calling ./configure, the possible outcomes of the
enable_benchmark variable are:
    
./configure                          -> ""
./configure --enable-benchmark       -> "yes"
./configure --enable-benchmark=yes   -> "yes"
./configure --enable-benchmark=no    -> "yes"
./configure --enable-benchmark=hello -> "yes"
./configure --disable-benchmark      -> "yes"
    
With the atteched patch, those values become
    
./configure                          -> ""
./configure --enable-benchmark       -> "yes"
./configure --enable-benchmark=yes   -> "yes"
./configure --enable-benchmark=no    -> "no"
./configure --enable-benchmark=hello -> "hello"
./configure --disable-benchmark      -> "no"
    
Note that enable_benchmark is currently only being checked for
being "yes" or not.

Comment 1 Murray Cumming 2016-11-20 10:47:59 UTC

Thanks. Pushed to git master and the libsigc++-2-10 branch.

I guess I didn't notice this because it shouldn't be necessary to explicitly disable the benchmark. Wasn't it enough to just not enable it?

Comment 2 kobboi 2016-11-20 11:18:58 UTC

Thanks for the quick feedback.

Sure, there were ways around it. But in Gentoo we have some code that automatically maps so-called USE flags to --enable/--disable arguments for ./configure and I preferred to keep that code the way it was (also because the "problem" might also pop up for other people compiling manually)

Comment 3 Kjell Ahlstedt 2016-11-24 08:58:56 UTC

I suppose this bug is fixed now, so I close it.