After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774723 - [PATCH] Fix printf format specifier
[PATCH] Fix printf format specifier
Status: RESOLVED FIXED
Product: libgnome-games-support
Classification: Other
Component: general
git master
Other Linux
: Normal major
: ---
Assigned To: libgames-scores maintainer(s)
libgames-scores maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-11-19 15:33 UTC by Alexandru Lincan
Modified: 2016-11-19 15:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix printf format specifier (1.15 KB, patch)
2016-11-19 15:33 UTC, Alexandru Lincan 		none Details | Review
Fix printf format specifier (1.15 KB, patch)
2016-11-19 15:39 UTC, Alexandru Lincan 		accepted-commit_now Details | Review

Description Alexandru Lincan 2016-11-19 15:33:02 UTC 
Created attachment 340311 [details] [review]
Fix printf format specifier

libgnome-games-support not building on master due to compilation error
Comment 1 Iulian Radu 2016-11-19 15:36:12 UTC 
Review of attachment 340311 [details] [review]:

::: games/scores/dialog.vala
@@ +276,3 @@
             score.set_text ("%s %s".printf (
                 /* Time which may be displayed on a scores dialog. */
+                ngettext ("%d minute", "%ld minutes", minutes).printf (minutes),

Also change the first %d

@@ +279,2 @@
                 /* Time which may be displayed on a scores dialog. */
+                ngettext ("%d second", "%ld seconds", seconds).printf (seconds)));

Ditto.
Comment 2 Alexandru Lincan 2016-11-19 15:39:11 UTC 
Created attachment 340312 [details] [review]
Fix printf format specifier
Comment 3 Iulian Radu 2016-11-19 15:39:36 UTC 
Review of attachment 340312 [details] [review]:

Thanks!