After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774640 - gst-rtsp-server: Enable building with MSVC
gst-rtsp-server: Enable building with MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Windows
: Normal enhancement
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-17 19:11 UTC by Scott D Phillips
Modified: 2016-11-19 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH gst-rtsp-server 1/2] client: update do_send_message to match type GstRTSPClientSendFunc (1.29 KB, patch)
2016-11-17 19:12 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-rtsp-server 2/2] Enable building with MSVC (13.17 KB, patch)
2016-11-17 19:12 UTC, Scott D Phillips
none Details | Review
[PATCH gst-rtsp-server v2 2/2] Enable building with MSVC (14.01 KB, patch)
2016-11-18 18:35 UTC, Scott D Phillips
committed Details | Review

Description Scott D Phillips 2016-11-17 19:11:33 UTC
I don't promise everything is functioning properly with these patches, but at least it builds.
Comment 1 Scott D Phillips 2016-11-17 19:12:32 UTC
Created attachment 340176 [details] [review]
[PATCH gst-rtsp-server 1/2] client: update do_send_message to match type GstRTSPClientSendFunc
Comment 2 Scott D Phillips 2016-11-17 19:12:51 UTC
Created attachment 340177 [details] [review]
[PATCH gst-rtsp-server 2/2] Enable building with MSVC
Comment 3 Sebastian Dröge (slomo) 2016-11-18 15:54:38 UTC
Comment on attachment 340177 [details] [review]
[PATCH gst-rtsp-server 2/2] Enable building with MSVC

This should come with the "check-exports" / "update-exports" magic we have in core/base to prevent forgetting updating the .def file
Comment 4 Scott D Phillips 2016-11-18 18:35:52 UTC
Created attachment 340260 [details] [review]
[PATCH gst-rtsp-server v2 2/2] Enable building with MSVC

Changes since v1:
- include win32.mak to enable check-exports
Comment 5 Sebastian Dröge (slomo) 2016-11-19 09:58:27 UTC
commit d7676bfba3ea33e13283787dc641e97cc0241cd9
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Thu Nov 17 09:41:53 2016 -0800

    Enable building with MSVC
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774640