After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774636 - git-update: fix running on windows
git-update: fix running on windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-build
git master
Other Windows
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-17 19:01 UTC by Scott D Phillips
Modified: 2016-11-17 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH gst-build] git-update: fixes for running on windows (1.33 KB, patch)
2016-11-17 19:01 UTC, Scott D Phillips 		committed Details | Review

Description Scott D Phillips 2016-11-17 19:01:12 UTC 
Couple small problems with the script on windows:
- SCRIPTDIR is '' when running as `py git-update` which gets set as a curdir and then fails creating a subprocess.
- Printing an emdash doesn't work in a windows console because strings get encoded into cp437 before printing and emdash isn't there.
Comment 1 Scott D Phillips 2016-11-17 19:01:57 UTC 
Created attachment 340169 [details] [review]
[PATCH gst-build] git-update: fixes for running on windows
Comment 2 Thibault Saunier 2016-11-17 20:52:36 UTC 
commit 978f107a0b560cdbc7cca6e53621d2c49c650d9d
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Thu Nov 17 10:55:44 2016 -0800

    git-update: fixes for running on windows
    
    when running git-update as `py git-update` (which is convenient on
    windows), SCRIPTDIR is '' instead of '.'. Fix that with normpath.
    
    Printing emdash (U+2014) doesn't work on windows because it isn't in
    cp437. Change it to hyphen.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774636