GNOME Bugzilla – Bug 774619
Default color palette is custom
Last modified: 2017-12-29 20:21:29 UTC
Fresh new account. Open Profile Prefs -> Colors. Notice that the "Palette" is set to "Custom". The default palette should be one of the pre-defined ones (perhaps creating a new pre-defined being gnome-terminal's current default, so one can easily revert to it). Not sure if related to / broken by commit 86e427b / bug 734875.
Created attachment 365972 [details] [review] Fix The pre-defined palettes are defined in profile-editor.c, whereas the default colors are defined in org.gnome.Terminal.gschema.xml under key name="palette". The latter is supposed to be a copy of Tango, but got out of sync in commit 730427d95 / bug #582861.
Comment on attachment 365972 [details] [review] Fix Thanks!
Actually let's stop for a moment and let's question whether the aforementioned fix for black was a correct one :) Tango isn't strictly speaking one particular color scheme of 16 colors, but it defines 27 colors at http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines and we pick out of these (which two columns of the three we pick arbitrarily changes from color to color; also cyan and bright cyan uses colors not present here, and black also differs now as per the linked change). I think it would be more correct to revert to Tango's dark aluminium, and introduce a corresponding entry for the bg+fg combo dropdown (using tango's light aluminium as foreground). It's easier for users to manually change black to be pitch black, rather than manually change it (as well as the background) to Tango's dark aluminium. By the way, the aforementioned fix fixes the "white on black" case but not the "black on white" one which is probably still broken in some sense. Reverting black, however, cries for color schemes to not only define the 16 colors but also their preferred default bg+fg (and perhaps other attributes) too, as it was already mentioned in bug 655030 & bug 728600. So maybe go for the above quick fix now and come back to this story later to have a more correct Tango.
I see that kde's colourscheme format already has bg/fg, so that's precendent for the colour scheme to include it; so let's do this quick-fix here, and leave the rest for bug 655030.
I'm still hesitant about this quick fix. This would actually change g-t's default. The Real Tango (with dark aluminium) has been g-t's default for 10 years now (commit 60dcbcd53), and it's not that people were complaining a lot about black not being pitch black. It's just that for the last 8 years it was accidentally called "Custom" in profile prefs (and you could no longer get back to it if you switched away), whereas "Tango" was the pitch black version. With this commit we'd change the default for all those users who don't bother fiddling with the prefs. If we address this bug at all (prior to the big refactoring), I'd probably feel more comfortable going the opposite direction and reverting bug 582861's commit.
Reverting bug 582861 is fine with me. - "#060698209A9A", + "#060698989A9A", This part is independent of the discussion above, and still correct.
Created attachment 365984 [details] [review] Fix, v2 part 1 (cleanup)
Created attachment 365985 [details] [review] Fix, v2 part 2 How about these two patches? The first one is cleanup only. This one reverts to tango's dark aluminium for black, adds two new fg/bg schemes with matching colors (although it's debatable whether Tango light's background should be the dark white or bright white), and makes "Tango dark" the default if someone unchecks "Use colors from system theme" (as opposed to the current green on black, which I don't think is a popular one, and especially doesn't play well with the default 16-color Tango palette).
Comment on attachment 365984 [details] [review] Fix, v2 part 1 (cleanup) Nice :-)
Comment on attachment 365985 [details] [review] Fix, v2 part 2 Ok.
Submitted.