After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774553 - Hide vino when using Wayland
Hide vino when using Wayland
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-16 14:59 UTC by Bastien Nocera
Modified: 2016-11-17 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sharing: Hide Vino when using Wayland (1.56 KB, patch)
2016-11-16 15:10 UTC, Felipe Borges
none Details | Review
sharing: Hide Vino when using Wayland (1.24 KB, patch)
2016-11-16 17:04 UTC, Felipe Borges
committed Details | Review

Description Bastien Nocera 2016-11-16 14:59:39 UTC
Until we have a replacement.
Comment 1 Felipe Borges 2016-11-16 15:10:58 UTC
Created attachment 340016 [details] [review]
sharing: Hide Vino when using Wayland

Since we don't support "Screen Sharing" under Wayland yet.
Comment 2 Bastien Nocera 2016-11-16 16:13:24 UTC
Review of attachment 340016 [details] [review]:

::: panels/sharing/cc-sharing-panel.c
@@ +1160,3 @@
   /* screen sharing */
+  /* Do not show Vino when using Wayland */
+  if (cc_sharing_panel_check_schema_available (self, VINO_SCHEMA_ID) && !GDK_IS_WAYLAND_DISPLAY (display))

This will fail to compile if gtk+ is compiled without Wayland support.
Comment 3 Felipe Borges 2016-11-16 17:04:11 UTC
Created attachment 340031 [details] [review]
sharing: Hide Vino when using Wayland

Since we don't support "Screen Sharing" under Wayland yet.
Comment 4 Bastien Nocera 2016-11-17 14:18:21 UTC
Review of attachment 340031 [details] [review]:

Sure for master and gnome-3-22
Comment 5 Felipe Borges 2016-11-17 15:06:06 UTC
Attachment 340031 [details] pushed as 02ab69b - sharing: Hide Vino when using Wayland