GNOME Bugzilla – Bug 774481
Few modules are missing copyright/license/disclaimer header
Last modified: 2016-11-21 14:02:04 UTC
Copyright, license, and disclaimer headers are missing in the following modules: - gnome-music.in - gnomemusic/views/__init__.py - gnomemusic/widgets/__init__.py
Created attachment 339949 [details] [review] Added missing copyrgiht/license/disclaimer headers
patch review seems non-functional atm, but copyrighting empty files might be a bit much? There's a typo in the commit msg and please take into account the gnome git commit msg guidelines @ https://wiki.gnome.org/Git/CommitMessages
Created attachment 339961 [details] [review] copyright: added missing copyright/license/disclaimer headers Copyright/license/disclaimer headers were added in the following modules: - gnome-music.in - gnomemusic/widgets/__init__.py - gnomemusic/views/__init__.py
Oh, fixed typo and improved git message. Regarding adding headers in empty files, it is up to you. I usually do it since it is also part of the software and it is some kind usual to add code in __init__ files. In fact, maybe a nice refactor would be to import all widgets and views into their dunder init. This would make code somekind clearer.
Created attachment 339969 [details] [review] copyright: added missing copyright/license/disclaimer headers Copyright/license/disclaimer headers were added in the following modules: - gnome-music.in - gnomemusic/widgets/__init__.py - gnomemusic/views/__init__.py
Created attachment 339971 [details] [review] copyright: added missing copyright/license/disclaimer headers Copyright/license/disclaimer headers were added in gnome-music.in.
I've removed copyright from empty files ;)
Comment on attachment 339971 [details] [review] copyright: added missing copyright/license/disclaimer headers Thanks for the patch.