After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774479 - If the original time in the timer is at least 1:00:00, reset sets the time wrong
If the original time in the timer is at least 1:00:00, reset sets the time wrong
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: timer
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-11-15 15:57 UTC by Tanu Kaskinen
Modified: 2016-12-09 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch fixes the timer's minutes being reset incorrectly. (1.21 KB, patch)
2016-12-07 04:13 UTC, Josh Brobst 		committed Details | Review

Description Tanu Kaskinen 2016-11-15 15:57:11 UTC 
I set the timer to 3:00:00, and after the timer expired, the time was reset to 3:59:00. I did some experiments, and whenever the original time is HH:MM:SS, where HH is at least 01, resetting the timer results in the time being set to HH:59:SS. That is, minutes always become 59, hours and seconds are preserved correctly. When HH is 00, this problem doesn't occur.
Comment 1 Tanu Kaskinen 2016-11-15 15:58:01 UTC 
Forgot to give the gnome-clocks version. It's 3.22.1-1 (Debian testing).
Comment 2 Josh Brobst 2016-12-07 04:13:45 UTC 
Created attachment 341527 [details] [review]
This patch fixes the timer's minutes being reset incorrectly.

This is my first time creating and submitting a patch so please let me know if I've done anything incorrectly!
Comment 3 Paolo Borelli 2016-12-08 14:34:55 UTC 
Review of attachment 341527 [details] [review]:

Patch looks good!

(I am currently traveling so I am not able to push it now)
Comment 4 Paolo Borelli 2016-12-09 20:37:59 UTC 
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.