GNOME Bugzilla – Bug 774473
api incompatible with libfreerdp 1.2
Last modified: 2021-05-26 09:25:42 UTC
Created attachment 339930 [details] A patch to fix the certificate validation callback compatibilities libfreerdp has changed the api of callbacks for certificate validation in the following commit: https://github.com/FreeRDP/FreeRDP/commit/cbf2892cccbd1052a45c41c5023c088100403164 It results in incompatibilities in the callback implementations in vinagre RDP plugin, and causes visible connection abort on openSUSE Leap 42.2: https://bugzilla.suse.com/show_bug.cgi?id=1002350
Same issue on Fedora 25 now (I was exceptionally confused why RDP wasn't working upon upgrade), I noticed Felix's patch was missing an #include <freerdp/version.h> so I'm attaching a corrected patch (it also returns a DWORD instead of int to correctly match the type signatures FreeRDP is expecting because GCC warnings annoy me). I'm working with the Fedora maintainers to get this locally patched, but it would be nice to get it upstreamed sooner than later.
Created attachment 342899 [details] [review] 0001-FreeRDP-1.2-certificate-callback-support.patch
(In reply to Stefan Nuxoll from comment #1) > Same issue on Fedora 25 now (I was exceptionally confused why RDP wasn't > working upon upgrade), I noticed Felix's patch was missing an #include > <freerdp/version.h> so I'm attaching a corrected patch (it also returns a > DWORD instead of int to correctly match the type signatures FreeRDP is > expecting because GCC warnings annoy me). Indeed. Thanks for the update on the patch. > > I'm working with the Fedora maintainers to get this locally patched, but it > would be nice to get it upstreamed sooner than later.
A cert update on the target machine cannot be recovered from due to this problem. Vinagre becomes useless. Blocker bug.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Vinagre, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/vinagre/-/issues/ Thank you for your understanding and your help.