After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774456 - Fix test failure caused by out-of-source build
Fix test failure caused by out-of-source build
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
3.22.x
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-15 08:34 UTC by Ting-Wei Lan
Modified: 2016-11-15 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: make TEST_DATA_DIR absolute (2.77 KB, patch)
2016-11-15 08:35 UTC, Ting-Wei Lan 		committed Details | Review
tests: Use srcdir instead of builddir to find test data (1.95 KB, patch)
2016-11-15 08:35 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-11-15 08:34:32 UTC 
I will attach two patches here to make TEST_DATA_DIR an absolute path and use G_TEST_SRCDIR instead of G_TEST_BUILDDIR.
Comment 1 Ting-Wei Lan 2016-11-15 08:35:42 UTC 
Created attachment 339898 [details] [review]
tests: make TEST_DATA_DIR absolute

$(srcdir) is not always a relative path, so prepending the path of
current directory doesn't always make a correct path.
Comment 2 Ting-Wei Lan 2016-11-15 08:35:48 UTC 
Created attachment 339899 [details] [review]
tests: Use srcdir instead of builddir to find test data
Comment 3 Christian Hergert 2016-11-15 11:07:53 UTC 
Review of attachment 339899 [details] [review]:

lgtm
Comment 4 Christian Hergert 2016-11-15 11:08:45 UTC 
Review of attachment 339898 [details] [review]:

lgtm, thanks!
Comment 5 Ting-Wei Lan 2016-11-15 13:05:20 UTC 
Attachment 339898 [details] pushed as eadbcc1 - tests: make TEST_DATA_DIR absolute
Attachment 339899 [details] pushed as fb3302c - tests: Use srcdir instead of builddir to find test data