After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774400 - gdiscreencapsrc: remove unused local variable
gdiscreencapsrc: remove unused local variable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal minor
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-14 11:27 UTC by Philippe Renon
Modified: 2016-11-14 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdiscreencapsrc: remove unused local variable (736 bytes, patch)
2016-11-14 11:27 UTC, Philippe Renon 		none Details | Review
gdiscreencapsrc: remove empty gst_gdiscreencapsrc_stop vfunc (1.85 KB, patch)
2016-11-14 17:01 UTC, Philippe Renon 		committed Details | Review

Description Philippe Renon 2016-11-14 11:27:02 UTC 
Created attachment 339791 [details] [review]
gdiscreencapsrc: remove unused local variable

Remove unused variable. Apparently master considers unused variables as errors (on msys2 at least).
Comment 1 Sebastian Dröge (slomo) 2016-11-14 11:48:22 UTC 
How is that a blocker? :)
Comment 2 Sebastian Dröge (slomo) 2016-11-14 11:48:57 UTC 
Comment on attachment 339791 [details] [review]
gdiscreencapsrc: remove unused local variable

Please remove the whole stop vfunc as it's completely empty now
Comment 3 Philippe Renon 2016-11-14 17:01:33 UTC 
Created attachment 339822 [details] [review]
gdiscreencapsrc: remove empty gst_gdiscreencapsrc_stop vfunc

New patch that takes into account review comments.
Comment 4 Sebastian Dröge (slomo) 2016-11-14 19:02:33 UTC 
Attachment 339822 [details] pushed as dcc7ab2 - gdiscreencapsrc: remove empty gst_gdiscreencapsrc_stop vfunc