GNOME Bugzilla – Bug 774368
Dependency file output of resource scanner breaks Ninja
Last modified: 2017-01-27 13:02:22 UTC
Gresource compiler recently got the ability to write dependency files. Its output currently looks roughly like this: res.xml: res1.dat res2.dat res1.dat: res2.dat: This is in theory correct. However it breaks Ninja, which can not currently handle more than one output rule in the dependency file (the relevant bug is https://github.com/ninja-build/ninja/issues/1184) It would be great if the dependency scanner would not print deps recursively, at least until Ninja is fixed. The dependency info for res1.dat and res2.dat is also useless so having it there only slows down the build. Thanks,
Just FYI: Typically those phony targets are added so that `make` won't complain if you remove a header file. (I don't know if your compiler is used in practice with `make` or if you always use `ninja`, but those are probably phony targets for the reason I just described, not "recursive" dependencies.) With GCC you have to ask it to generate the phony targets (with `-MP`) it isn't the default behaviour.
do you have a patch ?
Created attachment 339874 [details] [review] glib-compile-resources: Don't include phony targets in dep This just completely removes the phony targets. We could also add another argument to add the phony targets like mentioned in comment #1
Comment #1 seems to indicate that those rules do have some purpose, so adding an option might be good, just in case.
Created attachment 339931 [details] [review] glib-compile-resources: Add --generate-phony-targets flag
Created attachment 339939 [details] [review] glib-compile-resources: Add --generate-phony-targets flag (Forgot to update the man page entry)
Review of attachment 339931 [details] [review]: looks good. Would be nice to add the new option to the man page as well (see glib-compiles-resources.xml)
Review of attachment 339939 [details] [review]: like this :-)
Created attachment 339952 [details] [review] glib-compile-resources: Escape file names in dependency file During testing the previous patch I also encountered this issue. I can make a dedicated bug over it if preferred.
Review of attachment 339952 [details] [review]: ok
Comment on attachment 339952 [details] [review] glib-compile-resources: Escape file names in dependency file Pushed to master as 7a8cbc60a5410261fd02bedbe445c7e76167aa7c and 3a8ac6e2212a09944c845f9f2de50fd2b3c7ac61
This seems to be fixed; closing. Please reopen if I’ve got that incorrect.