After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774358 - Set line_comment_start to // instead of # for PHP language spec
Set line_comment_start to // instead of # for PHP language spec
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-13 13:58 UTC by markvk1986
Modified: 2016-11-13 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.10 KB, patch)
2016-11-13 13:58 UTC, markvk1986 		none Details | Review

Description markvk1986 2016-11-13 13:58:59 UTC 
Created attachment 339752 [details] [review]
patch

Even though both # and // can be used to comment a line, // seems to be most widely used and the use of # is discouraged by pear: http://pear.php.net/manual/en/standards.comments.php.

phpDocumentor (http://phpdoc.org) also uses // for documentation.

It might be good if this would be reflected in the language spec for PHP
Comment 1 Sébastien Wilmet 2016-11-13 15:11:03 UTC 
Thanks for the patch, pushed as commit c898605e66b70f9c50d63f009124915a3124bf08.
And backported to the gnome-3-24 branch.

(I've modified a little the commit message, the title should not exceed 72 chars).