After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774349 - MinGW: <config.h> is missing in gtksourceregion.c
MinGW: <config.h> is missing in gtksourceregion.c
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
: 774386 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-11-13 06:36 UTC by Kouhei Sutou
Modified: 2016-11-27 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the problem (772 bytes, patch)
2016-11-13 06:36 UTC, Kouhei Sutou 		none Details | Review

Description Kouhei Sutou 2016-11-13 06:36:35 UTC 
Created attachment 339740 [details] [review]
Fix the problem

gktsourceregion.c must include <config.h> to export symbols on Windows.
Because _GTK_SOURCE_EXTERN is defined in config.h. "__declspec(dllexport)" is required to export a symbol on Windows.
Comment 1 Sébastien Wilmet 2016-11-13 10:50:18 UTC 
Thanks, pushed as commit d6c07d063d3b4b0eaa579c5376046d8d6c02e9ae.
And backported on gnome-3-24 and gnome-3-22.
Comment 2 Fan, Chun-wei 2016-11-14 08:41:10 UTC 
*** Bug 774386 has been marked as a duplicate of this bug. ***
Comment 3 Sébastien Wilmet 2016-11-26 09:33:01 UTC 
Are there other build problems on Windows? Or can I do a new release?
Comment 4 Fan, Chun-wei 2016-11-26 10:58:31 UTC 
Hi,

From an MSVC viewpoint I think we are all set, as the items here apply to msvc builds as well.

With blessings, thank you!
Comment 5 Sébastien Wilmet 2016-11-27 10:11:55 UTC 
Ok, GtkSourceView 3.22.2 released.
Comment 6 Kouhei Sutou 2016-11-27 13:31:45 UTC 
I could build by MinGW without more additional patches.