After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774282 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks: 772263
 
 
Reported: 2016-11-11 16:43 UTC by Piotr Drąg
Modified: 2017-05-25 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Unicode in translatable strings (3.12 KB, patch)
2016-11-11 16:43 UTC, Piotr Drąg
none Details | Review
Use Unicode in translatable strings (3.17 KB, patch)
2017-04-06 14:34 UTC, Piotr Drąg
none Details | Review
Use Unicode in translatable strings (2.27 KB, patch)
2017-04-11 15:27 UTC, Piotr Drąg
none Details | Review
Use Unicode in translatable strings (2.72 KB, patch)
2017-05-24 20:28 UTC, Piotr Drąg
committed Details | Review

Description Piotr Drąg 2016-11-11 16:43:20 UTC
Created attachment 339637 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Piotr Drąg 2017-04-06 14:34:37 UTC
Created attachment 349383 [details] [review]
Use Unicode in translatable strings

Rebased on current master.
Comment 2 Piotr Drąg 2017-04-11 15:27:10 UTC
Created attachment 349685 [details] [review]
Use Unicode in translatable strings

Rebased again.
Comment 3 Piotr Drąg 2017-05-22 15:34:17 UTC
Comment on attachment 349685 [details] [review]
Use Unicode in translatable strings

These changes should be uncontroversial (two ellipses and one apostrophe), so I pushed it to master:

https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=6ddd07bae9673be17bea8062c9c813dd26263cbc
Comment 4 Piotr Drąg 2017-05-24 20:24:36 UTC
Comment on attachment 349685 [details] [review]
Use Unicode in translatable strings

I think this patch breaks g-t-t.

https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=9381930560f4472678bdd379dfd406d6adfab53e
Comment 5 Piotr Drąg 2017-05-24 20:28:18 UTC
Created attachment 352532 [details] [review]
Use Unicode in translatable strings

A new version of the patch, this time tested, and it works for me. Please review.
Comment 6 Rui Matos 2017-05-25 09:05:18 UTC
Review of attachment 352532 [details] [review]:

Looks good, thanks for the quick fix

::: gtweak/tweaks/tweak_group_shell.py
@@ +1,1 @@
+# This Python file uses the following encoding: utf-8

interesting, I didn't know about this
Comment 7 Piotr Drąg 2017-05-25 13:04:57 UTC
Comment on attachment 352532 [details] [review]
Use Unicode in translatable strings

Without these encoding lines, I was getting this message when trying to run the app:

SyntaxError: Non-ASCII character '\xe2' in file /[...]/gnome-tweak-tool/gtweak/tweaks/tweak_group_shell.py on line 74, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details


Pushed: https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=9c7f3bb9a752b9302f42aeefbadaee4279cb89fe

Thanks a lot!