GNOME Bugzilla – Bug 774282
Take advantage of Unicode
Last modified: 2017-05-25 13:05:07 UTC
Created attachment 339637 [details] [review] Use Unicode in translatable strings Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Created attachment 349383 [details] [review] Use Unicode in translatable strings Rebased on current master.
Created attachment 349685 [details] [review] Use Unicode in translatable strings Rebased again.
Comment on attachment 349685 [details] [review] Use Unicode in translatable strings These changes should be uncontroversial (two ellipses and one apostrophe), so I pushed it to master: https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=6ddd07bae9673be17bea8062c9c813dd26263cbc
Comment on attachment 349685 [details] [review] Use Unicode in translatable strings I think this patch breaks g-t-t. https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=9381930560f4472678bdd379dfd406d6adfab53e
Created attachment 352532 [details] [review] Use Unicode in translatable strings A new version of the patch, this time tested, and it works for me. Please review.
Review of attachment 352532 [details] [review]: Looks good, thanks for the quick fix ::: gtweak/tweaks/tweak_group_shell.py @@ +1,1 @@ +# This Python file uses the following encoding: utf-8 interesting, I didn't know about this
Comment on attachment 352532 [details] [review] Use Unicode in translatable strings Without these encoding lines, I was getting this message when trying to run the app: SyntaxError: Non-ASCII character '\xe2' in file /[...]/gnome-tweak-tool/gtweak/tweaks/tweak_group_shell.py on line 74, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details Pushed: https://git.gnome.org/browse/gnome-tweak-tool/commit/?id=9c7f3bb9a752b9302f42aeefbadaee4279cb89fe Thanks a lot!