After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774267 - nm-c-e: add a combo box to select special cloned MAC address values
nm-c-e: add a combo box to select special cloned MAC address values
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2016-11-11 13:23 UTC by Beniamino Galvani
Modified: 2017-01-16 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] editor: improve the cloned MAC address selection (25.08 KB, patch)
2016-11-11 13:24 UTC, Beniamino Galvani 		none Details | Review

Description Beniamino Galvani 2016-11-11 13:23:06 UTC 
Add a drop-down menu to select one of the special values as "Permanent", "Preserve", "Random" or "Stable" in the ethernet, vlan and wifi pages.
Comment 1 Beniamino Galvani 2016-11-11 13:24:45 UTC 
Created attachment 339622 [details] [review]
[PATCH] editor: improve the cloned MAC address selection
Comment 2 Thomas Haller 2016-11-11 15:06:24 UTC 
looks mostly good.

maybe it would really be nice to accept special strings list stable.
See for example what nmtui does:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/clients/tui/nmt-mac-entry.c?id=00ce005e51b26603c05fae99df401127ee68348d#n111
Comment 3 Beniamino Galvani 2016-11-15 07:52:10 UTC 
(In reply to Thomas Haller from comment #2)
> looks mostly good.
> 
> maybe it would really be nice to accept special strings list stable.
> See for example what nmtui does:

I'm not convinced it's that useful, since those values are already available through the drop down menu; and also, users would need to enter them untranslated.