After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774262 - Boost substitution variables (%1%) are an issue for translators
Boost substitution variables (%1%) are an issue for translators
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2016-11-11 12:05 UTC by Alexandre Franke
Modified: 2016-11-12 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (9.37 KB, patch)
2016-11-12 00:59 UTC, Hubert Figuiere (:hub) 		committed Details | Review

Description Alexandre Franke 2016-11-11 12:05:53 UTC 
%1% is unususal and translator get confused. It could be mistaken for a way to have a percentage displayed. Please either replace those by more common forms, or if you can't reasonably do it add a translator comment.

https://wiki.gnome.org/TranslationProject/DevGuidelines/Use%20comments
Comment 1 Claude Paroz 2016-11-11 13:05:14 UTC 
I'd like to second what Alexandre said.
Comment 2 Hubert Figuiere (:hub) 2016-11-12 00:59:03 UTC 
Created attachment 339676 [details] [review]
Proposed patch

This add translator comments in the proper place. And fixes a few places in .po where the format were wrong.
Comment 3 Hubert Figuiere (:hub) 2016-11-12 02:44:54 UTC 
And this should also be checked in 3.22 because I fixed some of the crashers.

Related bug 774142
Comment 4 Alexandre Franke 2016-11-12 13:36:10 UTC 
Review of attachment 339676 [details] [review]:

Just a minor nitpick: can you prefix all the relevant comments with "Translators:"? All comments above gettext calls end up in the po and translators may just ignore them if they don't see that they are the target.
Comment 5 Aurimas Černius 2016-11-12 13:55:43 UTC 
Comment on attachment 339676 [details] [review]
Proposed patch

Looks good to me. Should go to 3.22 too.
I'll have a deeper look if it's better to replace boost::format in a long run.
Comment 6 Hubert Figuiere (:hub) 2016-11-12 14:17:02 UTC 
i'll deal with comment 4 and push to master and 3.22
Comment 7 Hubert Figuiere (:hub) 2016-11-12 15:57:53 UTC 
Committed in 9538fc3f73777647c284debd3c6b768272dd8ca7

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 8 Hubert Figuiere (:hub) 2016-11-12 15:59:52 UTC 
In 3.22  532629a40dc880a603a87da8c9ddfd6bfcbe30e0