After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774242 - xattr: add user.xdg.tags support to displayed columns
xattr: add user.xdg.tags support to displayed columns
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: Metadata
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on: 773795
Blocks:
 
 
Reported: 2016-11-11 02:56 UTC by Felipe Barriga Richards
Modified: 2021-06-18 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of tags column (57.91 KB, image/png)
2016-11-11 02:56 UTC, Felipe Barriga Richards
  Details
tags column patch (15.57 KB, patch)
2016-11-11 02:57 UTC, Felipe Barriga Richards
rejected Details | Review

Description Felipe Barriga Richards 2016-11-11 02:56:53 UTC
Created attachment 339590 [details]
screenshot of tags column

Add support to display Tags column on list view.
- Sorting is working.
- Tags are readed from xattr: user.xdg.tags (related ticket: #773795)
- Patch and screenshot attached.
Comment 1 Felipe Barriga Richards 2016-11-11 02:57:38 UTC
Created attachment 339591 [details] [review]
tags column patch
Comment 2 Felipe Barriga Richards 2016-11-11 02:59:25 UTC
note: the attached patch need to be checked with valgrind...
Comment 3 Carlos Soriano 2016-11-11 09:02:26 UTC
thanks for the work on this! I think it makes sense and is a good first patch.
I would like to define the whole tags handling from a UI before going further, so we need designers here. Also, this blocks on https://bugzilla.gnome.org/show_bug.cgi?id=773795 , I will post a comment there now with yesterday's discussion with tracker maintainer
Comment 4 Carlos Soriano 2016-11-11 09:03:35 UTC
(In reply to Felipe Barriga Richards from comment #2)
> note: the attached patch need to be checked with valgrind...

This is something that need to be done by the implementor before contributing a patch, and also we would need to fix the FIXMES and TODOs you have in the patch.

Of course I understand this is a draft (and a good one) patch, so it's fine for now, not need to work more on that until we decide how to go with this :)
Comment 5 Carlos Soriano 2017-08-07 10:54:59 UTC
Review of attachment 339591 [details] [review]:

We decided to not have tags in the UI for now, so marking as rejected. Thanks for the work in any case!!
Comment 6 André Klapper 2021-06-18 15:54:07 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Files (nautilus), then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/nautilus/-/issues/

Thank you for your understanding and your help.