After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774212 - user-details "message" button not clear
user-details "message" button not clear
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-10 13:56 UTC by Lapo Calamandrei
Modified: 2017-08-02 00:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-details: Change message button label in userDetails (1.36 KB, patch)
2016-11-10 19:51 UTC, Danny Mølgaard 		committed Details | Review

Description Lapo Calamandrei 2016-11-10 13:56:09 UTC 
Having the label in the button something like "Start a conversation" would make things clearer.
Comment 1 Florian Müllner 2016-11-10 14:12:48 UTC 
Makes sense to me.
Comment 2 Danny Mølgaard 2016-11-10 19:51:42 UTC 
Created attachment 339539 [details] [review]
user-details: Change message button label in userDetails

'Message' can be both a noun and verb, thus resulting in confusion
in terms of its translation to other languages. It also makes more
sense to have the label correspond with the 'End Conversation'
available in the sidebar's right-click menu.

This commit changes the message button label in userDetails used by
userPopover and userList from 'Message' to 'Start Conversation'.
Comment 3 Florian Müllner 2016-11-11 11:22:05 UTC 
Review of attachment 339539 [details] [review]:

Code is obviously fine, some commit message nits:
 - Subject should be: "userDetails: Change message button label"
   (that is: camelCase the prefix, and don't repeat it unnecessarily)

 - avoid constructs like "this commit does/changes/implements/...";
   suggestion: Just make it a conclusion of the first paragraph:
   "[...] right-click menu, so change it to 'Start Conversation'."
Comment 4 Rishabh 2017-01-30 17:19:16 UTC 
Created https://github.com/GNOME/polari/pull/1
Comment 5 Florian Müllner 2017-01-30 21:43:37 UTC 
(In reply to Rishabh from comment #4)
> Created https://github.com/GNOME/polari/pull/1

We don't do pull requests, patches should be attached here. But note that there already *is* a patch for this particular issue, which just needs some fixups in the commit message.