After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774176 - telepathy-account-widgets depends unnecessarily on X11
telepathy-account-widgets depends unnecessarily on X11
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: tp-aw
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 774453
 
 
Reported: 2016-11-10 06:24 UTC by Philip Chimento
Modified: 2016-11-18 07:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove X11 dependency (1.03 KB, patch)
2016-11-10 06:25 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2016-11-10 06:24:54 UTC 
Fails to build on non-X11 systems. configure checks for X11 although that is not needed, and <gdk/gdkx.h> is included without a GDK_WINDOWING_X11 guard in a file that doesn't use it.
Comment 1 Philip Chimento 2016-11-10 06:25:22 UTC 
Created attachment 339428 [details] [review]
Remove X11 dependency
Comment 2 Debarshi Ray 2016-11-11 09:27:35 UTC 
Review of attachment 339428 [details] [review]:

Thanks Philip, looks good to me. I guess we should also update the git submodule in places like empathy and gnome-online-accounts?
Comment 3 Philip Chimento 2016-11-11 19:38:16 UTC 
Yes, please! (I ran into this from building gnome-online-accounts.) OK with you if I commit the git submodule updates too?
Comment 4 Philip Chimento 2016-11-11 19:40:02 UTC 
Comment on attachment 339428 [details] [review]
Remove X11 dependency

Attachment 339428 [details] pushed as a558072 - Remove X11 dependency
Comment 5 Philip Chimento 2016-11-17 03:29:18 UTC 
I updated the submodule in gnome-online-accounts, empathy, and gnome-chat.
Comment 6 Debarshi Ray 2016-11-18 07:59:55 UTC 
(In reply to Philip Chimento from comment #5)
> I updated the submodule in gnome-online-accounts, empathy, and gnome-chat.

Thanks for doing that! My apologies for not getting back sooner.