After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774168 - gobject introspection annotations and gtk-doc parser do not agree
gobject introspection annotations and gtk-doc parser do not agree
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.25
Other Linux
: Normal normal
: 1.26
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-09 21:35 UTC by Milan Crha
Modified: 2016-11-11 08:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Milan Crha 2016-11-09 21:35:28 UTC
I just noticed that the annotations for gobject introspection do not agree with the gtk-doc parser. Specifically with a #define comment:

   /**
    * E_NETWORK_MONITOR_ALWAYS_ONLINE_NAME: (value "always-online")
    *
    * A special name, which can be used as a GIO name in the call
    * to e_network_monitor_set_gio_name(), which is used to report
    * the the network as always reachable.
    *
    * Since: 3.22
    **/
   #define E_NETWORK_MONITOR_ALWAYS_ONLINE_NAME "always-online"

it results in a warning:

>  ..../src/libedataserver/e-network-monitor.h:59: warning: Symbol name not
>  found at the start of the comment block.

This is a no-win state for me, because I'd like to cover all (or at least most of) the gtk-doc and gobject-introspection warnings (thus it'll be easier to catch new issues during compile time), but I cannot reach it due to this issue.

It might be relatively easy to fix on the gtk-doc side, maybe?

This is with gtk-doc-1.25-1.fc25.x86_64.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2016-11-10 20:09:42 UTC
Meh, the docs never stated what can be in value and gtk-doc does not accept quotes. If I change that someone will add a string that contains a ')' and it will fall apart again :/

I'll add the quotes now, but imho the value annotation is underspecified.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2016-11-10 20:18:35 UTC
commit bc5d2bce65cbda332d45625c9f8ec147522f78a7
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Thu Nov 10 21:16:45 2016 +0100

    gtkdoc-mkdb: accept every char in an annotation
    
    It is unlikely that this format ever gets a formal specification. Hopefully
    has no sideeffects.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=774168
Comment 3 Milan Crha 2016-11-11 08:24:07 UTC
Thanks. I guess the value is quoted, because it's a string. But my knowledge on the introspection annotation is very limited.