After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774102 - Shotwell requires gexiv2 >= 0.10.4
Shotwell requires gexiv2 >= 0.10.4
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on: 774105
Blocks:
 
 
Reported: 2016-11-08 13:54 UTC by Pablo Castellano (IRC: pablog)
Modified: 2020-11-11 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pablo Castellano (IRC: pablog) 2016-11-08 13:54:30 UTC
Shotwell requires gexiv2 >= 0.10.4 which is not packaged in most distributions.

I'm trying to compile it in Ubuntu 16.10 (yakkety) which has 0.10.3.

I don't know how to add it to the moduleset so that it gets compiled instead of using the system version.

The following patch won't work. It fails because after autogen.sh you need to run ./configure and jhbuild follows to the build phase right after autogen.


diff --git a/modulesets/gnome-world.modules b/modulesets/gnome-world.modules
index 8ac73cf..f41ecf0 100644
--- a/modulesets/gnome-world.modules
+++ b/modulesets/gnome-world.modules
@@ -3414,4 +3414,8 @@
     </dependencies>
   </autotools>
 
+  <autotools id="gexiv2">
+      <branch/>
+  </autotools>
+
 </moduleset>
Comment 1 Michael Catanzaro 2016-11-08 14:23:29 UTC
Its autogen.sh is just broken if it doesn't run configure, so you'll need to avoid it entirely. Build it from a tarball instead of from git, and use autogen-sh="configure". Look at core-deps for examples of how to do this. But gexiv2 is in GNOME git, so we might as well just fix autogen.sh. The right way to write an autogen.sh for GNOME is shown here:

https://wiki.gnome.org/Projects/GnomeCommon/Migration

You just have to remove the glib-gettextize, gtkdocize, intltoolize lines.

Note that you need to add dependencies too. gexiv2 depends on exiv2, glib, gtkdoc, gobject-introspection, and vala.

Does it really work to have the module defined in two different places?
Comment 2 Michael Catanzaro 2016-11-08 14:23:52 UTC
(In reply to Michael Catanzaro from comment #1)
> Does it really work to have the module defined in two different places?

You probably need to give it a unique name: gexiv2-shotwell
Comment 3 Pablo Castellano (IRC: pablog) 2016-11-08 14:35:14 UTC
Thanks for your quick answer. I have already submitted a patch to fix gexiv2's autogen:

https://bugzilla.gnome.org/show_bug.cgi?id=774105
Comment 4 teramind 2017-12-08 15:39:31 UTC
I still get this error.
Comment 5 Christoph Reiter (lazka) 2020-11-11 18:24:31 UTC
We have a gexiv2 module now, so should be fixed.