After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774044 - meson: g-i: jhbuild build fails to pick up internal Gst-1.0 for GstBase-1.0.gir on Fedora24 without gstreamer1-devel
meson: g-i: jhbuild build fails to pick up internal Gst-1.0 for GstBase-1.0.g...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
https://github.com/mesonbuild/meson/i...
Depends on:
Blocks:
 
 
Reported: 2016-11-07 09:21 UTC by Mario Wenzel
Modified: 2016-11-09 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
complete output for that module (5.44 KB, patch)
2016-11-07 09:21 UTC, Mario Wenzel
none Details | Review
meson: Advertise dependency on gst_dep generating girs (2.17 KB, patch)
2016-11-09 17:11 UTC, Thibault Saunier
committed Details | Review

Description Mario Wenzel 2016-11-07 09:21:57 UTC
Created attachment 339232 [details] [review]
complete output for that module

I tried to build some stuff with jhbuild on F24 and it depended on gstreamer. I installed all dependencies that were needed (so all deps that jhbuild mentioned before starting to build). When it was time for gstreamer to build it failed and refused to be built until I installed gstreamer1-devel with dnf.

This was the last output (the complete output for that module is attached):

[311/440] 'Generating GstBase-1.0.typelib with a custom command.'
FAILED: libs/gst/base/GstBase-1.0.typelib 
'g-ir-compiler' 'libs/gst/base/GstBase-1.0.gir' '--output' 'libs/gst/base/GstBase-1.0.typelib'
Could not find GIR file 'Gst-1.0.gir'; check XDG_DATA_DIRS or use --includedir
error parsing file libs/gst/base/GstBase-1.0.gir: Failed to parse included gir Gst-1.0
[316/440] Compiling c object 'tests/check/gst/gsturi@exe/gst_gsturi.c.o'
ninja: build stopped: subcommand failed.
*** Fehler während Phase build von gstreamer: ########## Fehler beim Ausführen von ninja-build *** [20/78]

After installing gstreamer1-devel, everything compiles fine.

If this is a hard dependency, then jhbuild should mention that beforehand or, if possible, install it using existing mechanisms. I had to google for the package that includes 'Gst-1.0.gir' to find the proper one to install.
Comment 1 Tim-Philipp Müller 2016-11-07 10:24:28 UTC
This should not be a dependency at all. You are building the gstreamer1 package here after all. It should pick up Gst-1.0.gir from the internal build directory.

Could you run ninja-build -v -j1 and paste the full output for the g-ir-compiler command invocation which fails? Thanks!
Comment 2 Mario Wenzel 2016-11-07 12:11:43 UTC
After the failed build I used the [4]-option to get into the shell:

[jhbuild] mwenzel@mwenzel-desktop:/home/mwenzel/.cache/jhbuild/build/gstreamer
$ ninja-build -v -j1
[1/124] 'g-ir-compiler' 'libs/gst/base/GstBase-1.0.gir' '--output' 'libs/gst/base/GstBase-1.0.typelib'
FAILED: libs/gst/base/GstBase-1.0.typelib 
'g-ir-compiler' 'libs/gst/base/GstBase-1.0.gir' '--output' 'libs/gst/base/GstBase-1.0.typelib'
Could not find GIR file 'Gst-1.0.gir'; check XDG_DATA_DIRS or use --includedir
error parsing file libs/gst/base/GstBase-1.0.gir: Failed to parse included gir Gst-1.0
ninja: build stopped: subcommand failed.

That doesn't seem truly helpful
Comment 3 Tim-Philipp Müller 2016-11-07 12:18:08 UTC
Hrm, no, not really. I guess we'll have to try and reproduce it, I think this has come up elsewhere already.
Comment 4 Mario Wenzel 2016-11-07 12:28:13 UTC
I had this issue on two separate Fedora24 machines. So removing gstreamer1-devel you should have no issues reproducing it (but both machines have an almost identical setup, so you might still).

If there's anything else I can help with...
Comment 5 Tim-Philipp Müller 2016-11-08 12:23:53 UTC
Thanks. I've got a setup to reproduce this (or at least something similar, for me it fails already in the g-ir-scanner stage, not sure why that's not the case for you, but I'm sure it's the same issue). Will poke a bit.
Comment 6 Thibault Saunier 2016-11-09 17:11:47 UTC
Created attachment 339405 [details] [review]
meson: Advertise dependency on gst_dep generating girs

And do not simply link to libgst as the gir information
location only exist in declare_dependecy
Comment 7 Nirbheek Chauhan 2016-11-09 18:51:49 UTC
Review of attachment 339405 [details] [review]:

Huh, rather obvious fix. Funny that we missed it. Please push. :)
Comment 8 Thibault Saunier 2016-11-09 20:02:15 UTC
Attachment 339405 [details] pushed as 0079aea - meson: Advertise dependency on gst_dep generating girs