After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774042 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks: 772263
 
 
Reported: 2016-11-07 09:05 UTC by Piotr Drąg
Modified: 2017-08-11 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Unicode in translatable strings (7.67 KB, patch)
2016-11-07 09:05 UTC, Piotr Drąg
none Details | Review
pairing-dialog: Use Unicode in translatable strings (4.32 KB, patch)
2016-11-07 12:40 UTC, Piotr Drąg
committed Details | Review
settings: Use Unicode in translatable strings (2.94 KB, patch)
2016-11-07 12:40 UTC, Piotr Drąg
committed Details | Review
sendto: Use Unicode in translatable strings (1.25 KB, patch)
2016-11-07 12:40 UTC, Piotr Drąg
committed Details | Review

Description Piotr Drąg 2016-11-07 09:05:52 UTC
Created attachment 339230 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Bastien Nocera 2016-11-07 12:03:50 UTC
Review of attachment 339230 [details] [review]:

This needs to be split up for the different sub-directories, and the pattern for commit subjects to be followed.
Comment 2 Piotr Drąg 2016-11-07 12:40:06 UTC
Created attachment 339249 [details] [review]
pairing-dialog: Use Unicode in translatable strings
Comment 3 Piotr Drąg 2016-11-07 12:40:24 UTC
Created attachment 339250 [details] [review]
settings: Use Unicode in translatable strings
Comment 4 Piotr Drąg 2016-11-07 12:40:36 UTC
Created attachment 339251 [details] [review]
sendto: Use Unicode in translatable strings
Comment 5 Bastien Nocera 2016-11-07 14:10:15 UTC
Review of attachment 339249 [details] [review]:

Looks good.
Comment 6 Bastien Nocera 2016-11-07 14:10:49 UTC
Review of attachment 339250 [details] [review]:

Great
Comment 7 Bastien Nocera 2016-11-07 14:11:06 UTC
Review of attachment 339251 [details] [review]:

Looks good
Comment 8 Bastien Nocera 2016-11-07 14:12:26 UTC
Please branch master for gnome-3-20 before committing. Note: gnome-3-20
(there weren't any changes for 3.22)
Comment 9 Piotr Drąg 2017-08-11 15:17:18 UTC
Comment on attachment 339249 [details] [review]
pairing-dialog: Use Unicode in translatable strings

https://git.gnome.org/browse/gnome-bluetooth/commit/?id=df20a86ba1637b3989524d17e91e5cd5eaba4475
Comment 10 Piotr Drąg 2017-08-11 15:17:40 UTC
Comment on attachment 339250 [details] [review]
settings: Use Unicode in translatable strings

https://git.gnome.org/browse/gnome-bluetooth/commit/?id=feb9e2a34a57afd435dc62d3db5909259b32548c
Comment 11 Piotr Drąg 2017-08-11 15:17:52 UTC
Comment on attachment 339251 [details] [review]
sendto: Use Unicode in translatable strings

https://git.gnome.org/browse/gnome-bluetooth/commit/?id=52126e819d26c97b406c802882e1e258e7902476