After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774001 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks: 772263
 
 
Reported: 2016-11-06 14:47 UTC by Piotr Drąg
Modified: 2016-12-13 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use Unicode in translatable strings (13.70 KB, patch)
2016-11-06 14:47 UTC, Piotr Drąg
none Details | Review

Description Piotr Drąg 2016-11-06 14:47:03 UTC
Created attachment 339193 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Felix Riemann 2016-11-16 18:17:12 UTC
Review of attachment 339193 [details] [review]:

::: src/main.c
@@ +67,3 @@
 	{ "single-window", 'w', 0, G_OPTION_ARG_NONE, &single_window, N_("Open in a single window, if multiple windows are open the first one is used"), NULL },
 	{ "version", 0, G_OPTION_FLAG_NO_ARG, G_OPTION_ARG_CALLBACK,
+	  _print_version_and_exit, N_("Show the application’s version"), NULL},

Hmm, I am not so sure about these. These go to the terminal. If you don't use a Unicode-aware locale (like C) it will print ? in place of the unicode glyphs. Or we assume that the majority will use Unicode locales...
Comment 2 Piotr Drąg 2016-11-18 13:51:06 UTC
$ LANG=pl_PL.ISO-8859-2
$ rpm
RPM wersja 4.13.0-rc1
Copyright (C) 1998-2002 -- Red Hat, Inc.
Ten program mo�e by� swobodnie rozpowszechniany na warunkach licencji GNU GPL
[cut some lines]
        [-E|--eval=„WYRAŻENIE”] [--macros=<PLIK:…>] [--noplugins]


I don't know how reliable of a test it is, but changing pl_PL.UTF-8 to pl_PL.ISO-8859-2 makes Polish special characters unreadable, but ellipses and quotation marks show up just fine, and the em-dash turns into "--". mc does similar, but changes also Unicode ellipses into three dots.
Comment 3 Piotr Drąg 2016-11-18 13:52:34 UTC
(The part about Polish characters is the expected behaviour.)
Comment 4 Felix Riemann 2016-12-13 18:30:58 UTC
Oh, I didn't notice this was already happening. I guess we can live with that then.

commit 7684b1157b23228bbd6e4f13436224837a680b0e
Author: Piotr Drąg <>
Date:   Sun Nov 6 15:45:08 2016 +0100

    Use Unicode in translatable strings
    
    See https://developer.gnome.org/hig/stable/typography.html
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774001