After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773995 - Take advantage of Unicode
Take advantage of Unicode
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks: 772263
 
 
Reported: 2016-11-06 13:08 UTC by Piotr Drąg
Modified: 2016-11-07 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use Unicode in translatable strings (1.81 KB, patch)
2016-11-06 13:08 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2016-11-06 13:08:55 UTC 
Created attachment 339189 [details] [review]
Use Unicode in translatable strings

Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Comment 1 Daiki Ueno 2016-11-06 18:52:30 UTC 
Review of attachment 339189 [details] [review]:

::: caribou/antler/antler_settings.py
@@ +11,3 @@
                             _("The keyboard geometry determines the shape "
                               "and complexity of the keyboard, it could range from "
+                              "a “natural” look and feel good for composing simple "

Can't this be done with the en@quot catalog instead of hard-coding the Unicode quotation characters?
Comment 2 Piotr Drąg 2016-11-06 18:55:38 UTC 
I don't know anything about en@quot. My assumption is that it's beneficial to just use correct typography in UI strings.
Comment 3 Daiki Ueno 2016-11-07 06:56:13 UTC 
Review of attachment 339189 [details] [review]:

Sorry, you are right.  I'm a bit tired of this kind of change and hoped a generic mechanism to handle I18N quotations, like quotearg in coreutils: https://www.gnu.org/software/coreutils/manual/html_node/Formatting-the-file-names.html#Formatting-the-file-names

::: daemon/daemon.vala
@@ +216,2 @@
     var option_context = new OptionContext (_(
+        "— accessibility event monitoring daemon for screen keyboard"));

Now that 'caribou' is installed under libexec, which means that it is not used interactively, I doubt it is worthwhile to have such a fancy help message.

Maybe we could simply pass NULL here?
Comment 4 Piotr Drąg 2016-11-07 07:07:11 UTC 
Thank you, I pushed the patch.
Comment 5 Mario Wenzel 2016-11-07 09:33:40 UTC 
This breaks the jhbuild build

Traceback (most recent call last):

+ Trace 236838

  • File "/home/mwenzel/gnome/source/caribou/tools/make_schema.py", line 101 in <module> 
    module = __import__(modulename, locals(), globals(), [settings_obj])
  • File "/home/mwenzel/gnome/source/caribou/caribou/antler/__init__.py", line 1 in <module> 
    from .antler_settings import AntlerSettings
  • File "/home/mwenzel/gnome/source/caribou/caribou/antler/antler_settings.py", line 13
SyntaxError: Non-ASCII character '\xe2' in file /home/mwenzel/gnome/source/caribou/caribou/antler/antler_settings.py on line 13, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details 






Comment 6


Daiki Ueno





          2016-11-07 09:54:48 UTC
        



(In reply to Mario Wenzel from comment #5)
> This breaks the jhbuild build
> 
> Traceback (most recent call last):

It should be fixed now with:
https://git.gnome.org/browse/caribou/commit/?id=0d52ffe408c3f5c0bb8411f8d504dfe97b9124c2