After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773983 - when building a project all files should be saved automatically
when building a project all files should be saved automatically
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
3.22.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-05 16:05 UTC by Peter Sonntag
Modified: 2016-11-06 08:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build-manager: save all buffers before dispatching build (6.47 KB, patch)
2016-11-06 08:14 UTC, Christian Hergert 		committed Details | Review

Description Peter Sonntag 2016-11-05 16:05:53 UTC 
When one builds or executes a project, all files should be saved automatically before rebuild.

Right now, changes in the code are neglected. When I execute a project, I want it to be the latest version of all files.

Version 3.22.2
Comment 1 Christian Hergert 2016-11-06 07:22:05 UTC 
Hrmm, if we aren't doing that, its definitely a bug. Possibly crept in when I refactored the IdeBuildManager.
Comment 2 Christian Hergert 2016-11-06 08:14:20 UTC 
Created attachment 339186 [details] [review]
build-manager: save all buffers before dispatching build

This was fallout from moving to IdeBuildManager.

The patch ensures that we save all buffers asynchronously while we perform
a build. To ensure that "busy" is set to true during the save operation,
we add a new "saving" bit and use that to calculate get_busy().
Comment 3 Christian Hergert 2016-11-06 08:16:41 UTC 
Attachment 339186 [details] pushed as 4fa80bc - build-manager: save all buffers before dispatching build