After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773977 - Invalid type of writable-change-event key parameter
Invalid type of writable-change-event key parameter
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: giomm
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2016-11-05 12:06 UTC by Marcin Kolny (IRC: loganek)
Modified: 2016-11-14 09:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed solution (2.05 KB, patch)
2016-11-05 12:07 UTC, Marcin Kolny (IRC: loganek)
committed Details | Review

Description Marcin Kolny (IRC: loganek) 2016-11-05 12:06:11 UTC
Parameter key in Gio::Settings::writable-change-event signal should be of type GQuark, not guint. However, my patch doesn't break the API, because:

typedef guint32 GQuark;
typedef unsigned int guint32;
typedef unsigned int guint;

Please review. If no objections, I'll push it.

Btw, I've discovered this bug writing new mm .defs generator based on gobject-introspection (in the future I think it could generate more advanced output, like .hg/ccg or something else)[1]. Still a lot of work before it can be replacement for our current python/perl/c++ programs for generating defs file, but I think it goes in right direction.

[1] https://github.com/loganek/mmgirgenerator
Comment 1 Marcin Kolny (IRC: loganek) 2016-11-05 12:07:13 UTC
Created attachment 339166 [details] [review]
proposed solution
Comment 2 Murray Cumming 2016-11-05 16:04:26 UTC
Yes, the C documentation does say that it should be a GQuark, though it shows it as guint in its example handler, because there is no G_TYPE_QUARK.

Please go ahead.
Comment 3 Kjell Ahlstedt 2016-11-14 09:20:53 UTC
Has been fixed in glibmm's master branch. I suppose this bug shall be closed.