After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773950 - Smoother dynamic cover placement when resizing the window
Smoother dynamic cover placement when resizing the window
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-04 17:42 UTC by Laurent Pointecouteau
Modified: 2017-01-31 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Smooth collection icons arrangement when resizing window. (1009 bytes, patch)
2017-01-28 10:33 UTC, Abhinav Singh
none Details | Review
Smooth collection icons arrangement when resizing window. (1.60 KB, patch)
2017-01-28 11:07 UTC, Abhinav Singh
none Details | Review
Smooth out collection icons arrangement (1.62 KB, patch)
2017-01-31 10:36 UTC, Abhinav Singh
committed Details | Review

Description Laurent Pointecouteau 2016-11-04 17:42:17 UTC
Currently, resizing Games' window only does not move the covers until reaching the extra width for a new column to fit into the window. Music has a smoother way to display this; could Games use the same too?
Comment 1 Abhinav Singh 2017-01-28 10:33:22 UTC
Created attachment 344450 [details] [review]
Smooth collection icons arrangement when resizing window.

This is one possible solution.
By setting halign to fill, all the icon views stretch out evenly (thumbnails remains same size). Just the boundary of icon views stretches out.
Comment 2 Abhinav Singh 2017-01-28 11:07:13 UTC
Created attachment 344451 [details] [review]
Smooth collection icons arrangement when resizing window.

This is another possible solution.
By setting halign to fill on collection view and disabling expand on icon view, we get variable spaces between the icon views. They do not stretch out.

IMO the previous patch is a better choice.
Comment 3 Adrien Plazas 2017-01-31 07:27:42 UTC
Review of attachment 344450 [details] [review]:

The other patch is closer to the design of other similar GNOME apps so let's it rather than this one.
Comment 4 Adrien Plazas 2017-01-31 07:33:53 UTC
Review of attachment 344451 [details] [review]:

The short log shouldn't exceed 52 chars, for example these two would be better:
ui: Smooth out collection icons arrangement
ui: Make collection icons arrangement smoother

The phrasing of the commit message doesn't exactly fulfill to our standards but I don't mind it that much, bonus point if you make it closer to our commit message style. ;)
Comment 5 Abhinav Singh 2017-01-31 10:36:11 UTC
Created attachment 344638 [details] [review]
Smooth out collection icons arrangement