After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773885 - pop down GtkPopover on pressing escape
pop down GtkPopover on pressing escape
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkPopover
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-11-03 11:09 UTC by Ernestas Kulik
Modified: 2016-11-03 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
popover: pop down when pressing escape (825 bytes, patch)
2016-11-03 11:09 UTC, Ernestas Kulik
none Details | Review
popover: pop down when pressing escape (839 bytes, patch)
2016-11-03 13:42 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2016-11-03 11:09:05 UTC
Seeing this in Nautilus kind of bugs me. Is there a reason why hiding is used over popdown?

Attaching a patch as well.
Comment 1 Ernestas Kulik 2016-11-03 11:09:39 UTC
Created attachment 339017 [details] [review]
popover: pop down when pressing escape

Simply hiding the popover may introduce inconsistencies in application
behavior, since popping up/down is the usual use case.
Comment 2 Ernestas Kulik 2016-11-03 11:10:15 UTC
(In reply to Ernestas Kulik from comment #0)
> Seeing this in Nautilus

Err, seeing hide() used over popdown(), I mean.
Comment 3 Carlos Garnacho 2016-11-03 13:20:34 UTC
Comment on attachment 339017 [details] [review]
popover: pop down when pressing escape

Probably just an oversight from when popup/popdown API was added. LGTM, thanks.
Comment 4 Ernestas Kulik 2016-11-03 13:32:45 UTC
Argh, I forgot to add a cast. Push to master and 3.22 after I fix it up?
Comment 5 Ernestas Kulik 2016-11-03 13:42:03 UTC
Created attachment 339025 [details] [review]
popover: pop down when pressing escape

Simply hiding the popover may introduce inconsistencies in application
behavior, since popping up/down is the usual use case.
Comment 6 Ernestas Kulik 2016-11-03 13:46:30 UTC
Attachment 339025 [details] pushed as 3885e85 - popover: pop down when pressing escape