GNOME Bugzilla – Bug 773885
pop down GtkPopover on pressing escape
Last modified: 2016-11-03 13:49:01 UTC
Seeing this in Nautilus kind of bugs me. Is there a reason why hiding is used over popdown? Attaching a patch as well.
Created attachment 339017 [details] [review] popover: pop down when pressing escape Simply hiding the popover may introduce inconsistencies in application behavior, since popping up/down is the usual use case.
(In reply to Ernestas Kulik from comment #0) > Seeing this in Nautilus Err, seeing hide() used over popdown(), I mean.
Comment on attachment 339017 [details] [review] popover: pop down when pressing escape Probably just an oversight from when popup/popdown API was added. LGTM, thanks.
Argh, I forgot to add a cast. Push to master and 3.22 after I fix it up?
Created attachment 339025 [details] [review] popover: pop down when pressing escape Simply hiding the popover may introduce inconsistencies in application behavior, since popping up/down is the usual use case.
Attachment 339025 [details] pushed as 3885e85 - popover: pop down when pressing escape