After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771614 - No animation for rename popup.
No animation for rename popup.
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: All
master
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-18 09:47 UTC by Maxim
Modified: 2017-01-05 16:05 UTC
See Also:
GNOME target: ---
GNOME version: 3.21/3.22

Attachments
rename-file-popover-controller: Fix popover animation (1.66 KB, patch)
2016-10-27 20:41 UTC, Alexandru Pandelea 		committed Details | Review
files-view: use gtk_popover_pop{up,down} for rename popover (1.39 KB, patch)
2016-11-07 17:27 UTC, Ernestas Kulik 		committed Details | Review

Description Maxim 2016-09-18 09:47:35 UTC 
No animation for rename popup.
See comparsion between 3.20 vs 3.22
https://youtu.be/gg8763UcCK8
Comment 1 Alexandru Pandelea 2016-10-27 20:41:14 UTC 
Created attachment 338638 [details] [review]
rename-file-popover-controller: Fix popover animation

The transitions for the rename popover are disabled.

To fix this, use gtk_popover_popdown and gtk_popover_popup instead of
gtk_widget_show and gtk_widget_hide.
Comment 2 Ernestas Kulik 2016-11-03 06:17:22 UTC 
Review of attachment 338638 [details] [review]:

LGTM.

Pressing escape still only hides them, but that is GTK+, not Nautilus.
I will see if I can convince GTK+ people to do popdowns instead of hides. :p
Comment 3 Alexandru Pandelea 2016-11-04 10:07:24 UTC 
Attachment 338638 [details] pushed as 3a7ec46 - rename-file-popover-controller: Fix popover animation
Comment 4 Maxim 2016-11-07 16:00:47 UTC 
(In reply to Alexandru Pandelea from comment #3)
> Attachment 338638 [details] pushed as 3a7ec46 -
> rename-file-popover-controller: Fix popover animation

Will we see this fix in the 320?
Comment 5 Ernestas Kulik 2016-11-07 17:27:55 UTC 
Created attachment 339262 [details] [review]
files-view: use gtk_popover_pop{up,down} for rename popover

Popover transitions are not used for the rename popover.
Comment 6 Ernestas Kulik 2016-11-07 17:28:51 UTC 
(In reply to Maxim from comment #4)
> (In reply to Alexandru Pandelea from comment #3)
> > Attachment 338638 [details] pushed as 3a7ec46 -
> > rename-file-popover-controller: Fix popover animation
> 
> Will we see this fix in the 320?

That particular patch does not apply to the branch. I have posted one in comment 5.
Comment 7 Carlos Soriano 2016-11-22 16:37:34 UTC 
Review of attachment 339262 [details] [review]:

oh yes, sorry for taking long to review!
Comment 8 Ernestas Kulik 2016-11-23 20:00:40 UTC 
Comment on attachment 339262 [details] [review]
files-view: use gtk_popover_pop{up,down} for rename popover

Attachment 339262 [details] pushed as d3ff53d - files-view: use gtk_popover_pop{up,down} for rename popover
Comment 9 Carlos Soriano 2017-01-05 16:05:29 UTC 
reverted in 3.20, we didn't have gtk_popover_popdown back then