GNOME Bugzilla – Bug 773847
[Dark theme] some minor contrast issues
Last modified: 2017-04-21 20:32:51 UTC
There are some minor issues on dark themes: 1. red font in "Scheduled" view (GtkLabel date-overdue) is hard to read. Making it a bit lighter on Adwaita:dark should fix this. rgb(204, 50, 50) is much more readable than the currently applied rgb(204, 0, 0). 2. When opening a task list, there is a small symbol next to the ckeckbox which seems to be used to grab and reorder tasks. On Adwaita:light, they are dark enough to match font color. On Adwaita:dark they are too light and thus barely visible. Suggested solution: keep the same color as the font used for task due date ("task_date_label"), which is a good choice from what I can tell.
Created attachment 350137 [details] [review] scheduled-panel: move CSS to the panel This was a leftover that happened when the Scheduled panel moved out of the EDS plugin. The CSS should've been moved too.
Created attachment 350138 [details] [review] scheduled-panel: improve overdue label color Make it slightly brighter, so it looks good both on dark and light themes.
Created attachment 350139 [details] [review] theme: make DnD icon more proeminent This style change makes the DnD icon more proeminent by making it darker.
Hi Christian, Thanks for reporting this issue. I attached some patches here that I believe fix the issue. Could you please test them and report if they indeed fix it and improve the dark theme mode?
Created attachment 350145 [details] Imporved dark theme The drag icon and date label were visible with bright colors earlier, after applying the patch i tried to take some screenshot with dull colors and the label and drag icon seems much better and clear.
Created attachment 350146 [details] Another screenshot Another screenshot.
I'll just assume they work nice (per Kaushik's screenshots) and push them. Feel free to reopen this bug if you think it's not enough.
Attachment 350137 [details] pushed as 3e8578f - scheduled-panel: move CSS to the panel Attachment 350138 [details] pushed as f3ddecb - scheduled-panel: improve overdue label color Attachment 350139 [details] pushed as be3ac42 - theme: make DnD icon more proeminent
Thanks! I'll report back if something looks wrong to me.