After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773836 - Tasks added via 'Unscheduled panel' goes to nowhere
Tasks added via 'Unscheduled panel' goes to nowhere
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: General
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-11-02 16:26 UTC by Mohammed Sadiq
Modified: 2017-03-01 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
unscheduled-panel: fix task loss issue (2.15 KB, patch)
2017-02-21 12:52 UTC, Monica Baluna
none Details | Review
unscheduled-panel: fix task loss issue (2.15 KB, patch)
2017-03-01 13:49 UTC, Monica Baluna
committed Details | Review

Description Mohammed Sadiq 2016-11-02 16:26:04 UTC
Tasks added via 'Unscheduled Panel' doesn't go to 'Personal' (or any other) list. Also, the task isn't retained on restart of GNOME todo.
Comment 1 Christian Stadelmann 2016-11-02 17:41:13 UTC
I can confirm this issue. It also causes a warning message printed by gnome-todo:

** (gnome-todo:1488): CRITICAL **: gtd_provider_create_task: assertion 'GTD_IS_PROVIDER (provider)' failed
Comment 2 Monica Baluna 2017-02-21 12:52:32 UTC
Created attachment 346318 [details] [review]
unscheduled-panel: fix task loss issue

The tasklist used by the unscheduled panel does not have an associated provider.
This generates an error when attempting to create a task. In order to fix this,
do not explicitly set a task list for the view. In this way, the default
provider will be used, just like in the other plugins.
Comment 3 Georges Basile Stavracas Neto 2017-02-22 12:32:04 UTC
Review of attachment 346318 [details] [review]:

Thanks for the contribution! At a first glance, the code looks good. However, there is a problem with it: it's malformed, and I couldn't test it... Looking at it, I see no git headers. Make sure to attach a valid patch (let me know if you need any help with that). Alternatively, you can use git-bz and automate this process :)
Comment 4 Monica Baluna 2017-02-22 13:50:41 UTC
Hi! I've tried running "git bz apply 773836" and it worked for me locally. I'm not sure I understand what the problem is.
Comment 5 Monica Baluna 2017-03-01 13:49:28 UTC
Created attachment 346968 [details] [review]
unscheduled-panel: fix task loss issue

The tasklist used by the unscheduled panel does not have an associated provider.
This generates an error when attempting to create a task. In order to fix this,
do not explicitly set a task list for the view. In this way, the default
provider will be used, just like in the other plugins.
Comment 6 Georges Basile Stavracas Neto 2017-03-01 14:14:05 UTC
Review of attachment 346968 [details] [review]:

Looks very good to me, thanks!
Comment 7 Georges Basile Stavracas Neto 2017-03-01 14:14:46 UTC
Thanks for the patch!

Attachment 346968 [details] pushed as b71faa9 - unscheduled-panel: fix task loss issue