After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773831 - undo-file-manager: make the class final and port to G_DECLARE* type declaration
undo-file-manager: make the class final and port to G_DECLARE* type declaration
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 771777
 
 
Reported: 2016-11-02 14:10 UTC by Zurzic Zeljko
Modified: 2016-11-02 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
undo-file-manager: make the class final and port to G_DECLARE* type declaration (10.71 KB, patch)
2016-11-02 14:10 UTC, Zurzic Zeljko 		none Details | Review
undo-file-manager: make the class final and port to G_DECLARE* type declaration (10.49 KB, patch)
2016-11-02 14:23 UTC, Zurzic Zeljko 		none Details | Review
undo-file-manager: make the class final and port to G_DECLARE* type declaration (10.48 KB, patch)
2016-11-02 14:30 UTC, Zurzic Zeljko 		committed Details | Review

Description Zurzic Zeljko 2016-11-02 14:10:15 UTC 
See patch.
Comment 1 Zurzic Zeljko 2016-11-02 14:10:18 UTC 
Created attachment 338951 [details] [review]
undo-file-manager: make the class final and port to G_DECLARE* type declaration

Changed the old GObject class declarations in order to use smart pointers to
generate some functionalities and make the code more readable.

The class should not be derivable as its` functionality logics requires it to be
final.

To fix this use G_DECLARE* type and make the class final instead of derivable.
Comment 2 Razvan Chitu 2016-11-02 14:18:10 UTC 
Review of attachment 338951 [details] [review]:

LGTM besides the changes mentioned.

::: src/nautilus-file-undo-manager.c
@@ -85,3 @@
 {
     NautilusFileUndoManager *self = user_data;
-

This empty line should not be deleted.

@@ -240,3 @@
 {
     DEBUG ("Setting undo information %p", info);
-

This empty line should not be deleted.
Comment 3 Zurzic Zeljko 2016-11-02 14:23:57 UTC 
Created attachment 338952 [details] [review]
undo-file-manager: make the class final and port to G_DECLARE* type declaration

Changed the old GObject class declarations in order to use smart pointers to
generate some functionalities and make the code more readable.

The class should not be derivable as its` functionality logics requires it to be
final.

To fix this use G_DECLARE* type and make the class final instead of derivable.
Comment 4 Zurzic Zeljko 2016-11-02 14:30:27 UTC 
Created attachment 338954 [details] [review]
undo-file-manager: make the class final and port to G_DECLARE* type declaration

Changed the old GObject class declarations in order to use smart pointers to
generate some functionalities and make the code more readable.

The class should not be derivable as its functionality requires it to be
final.

To fix this use G_DECLARE* type and make the class final instead of derivable.
Comment 5 Razvan Chitu 2016-11-02 14:52:19 UTC 
Review of attachment 338954 [details] [review]:

LGTM now, let's wait for Carlos / Ernestas to look at it too.
Comment 6 Ernestas Kulik 2016-11-02 14:58:12 UTC 
Review of attachment 338954 [details] [review]:

LGTM as well. Thanks!
Comment 7 Razvan Chitu 2016-11-02 16:23:04 UTC 
Attachment 338954 [details] pushed as 21a510a - undo-file-manager: make the class final and port to G_DECLARE* type declaration