After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773729 - Playqueue UI improvements
Playqueue UI improvements
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-31 18:12 UTC by gnome.vrb
Modified: 2016-10-31 21:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
play-queue: Be consistent with playing text in header bar (1002 bytes, patch)
2016-10-31 18:15 UTC, gnome.vrb
committed Details | Review
play-queue: Use 75% alpha for playqueue smaller text (1.79 KB, patch)
2016-10-31 18:16 UTC, gnome.vrb
rejected Details | Review
Screenshot: With the changes ( Adwaita light theme ) (78.70 KB, image/png)
2016-10-31 18:17 UTC, gnome.vrb
  Details
Screenshot: With the changes ( Adwaita dark theme ) (79.78 KB, image/png)
2016-10-31 18:18 UTC, gnome.vrb
  Details

Description gnome.vrb 2016-10-31 18:12:46 UTC
1. Be consistent with playing text in header bar

2. Use 75% alpha for playqueue smaller text
Comment 1 gnome.vrb 2016-10-31 18:15:31 UTC
Created attachment 338839 [details] [review]
play-queue: Be consistent with playing text in header bar
Comment 2 gnome.vrb 2016-10-31 18:16:17 UTC
Created attachment 338840 [details] [review]
play-queue: Use 75% alpha for playqueue smaller text

Looks better than the current 100% alpha.
Comment 3 gnome.vrb 2016-10-31 18:17:43 UTC
Created attachment 338841 [details]
Screenshot: With the changes ( Adwaita light theme )
Comment 4 gnome.vrb 2016-10-31 18:18:13 UTC
Created attachment 338842 [details]
Screenshot: With the changes ( Adwaita dark theme )
Comment 5 Jonathan Matthew 2016-10-31 20:59:56 UTC
(In reply to vrishab from comment #2)
> Created attachment 338840 [details] [review] [review]
> play-queue: Use 75% alpha for playqueue smaller text
> 
> Looks better than the current 100% alpha.

no it doesn't.
Comment 6 Jonathan Matthew 2016-10-31 21:28:03 UTC
Review of attachment 338840 [details] [review]:

the text is already smaller, I really don't think we need to make it any harder to read.

::: sources/rb-play-queue-source.c
@@ +496,3 @@
+	color_hex = g_strdup_printf ("#%X%X%X", (guint8) (color_rgba.red * 255),
+				     (guint8) (color_rgba.green * 255),
+				     (guint8) (color_rgba.blue * 255));

this leaks the string, by the way
Comment 7 Jonathan Matthew 2016-10-31 21:36:52 UTC
Review of attachment 338839 [details] [review]:

pushed as commit acea894