GNOME Bugzilla – Bug 773729
Playqueue UI improvements
Last modified: 2016-10-31 21:37:04 UTC
1. Be consistent with playing text in header bar 2. Use 75% alpha for playqueue smaller text
Created attachment 338839 [details] [review] play-queue: Be consistent with playing text in header bar
Created attachment 338840 [details] [review] play-queue: Use 75% alpha for playqueue smaller text Looks better than the current 100% alpha.
Created attachment 338841 [details] Screenshot: With the changes ( Adwaita light theme )
Created attachment 338842 [details] Screenshot: With the changes ( Adwaita dark theme )
(In reply to vrishab from comment #2) > Created attachment 338840 [details] [review] [review] > play-queue: Use 75% alpha for playqueue smaller text > > Looks better than the current 100% alpha. no it doesn't.
Review of attachment 338840 [details] [review]: the text is already smaller, I really don't think we need to make it any harder to read. ::: sources/rb-play-queue-source.c @@ +496,3 @@ + color_hex = g_strdup_printf ("#%X%X%X", (guint8) (color_rgba.red * 255), + (guint8) (color_rgba.green * 255), + (guint8) (color_rgba.blue * 255)); this leaks the string, by the way
Review of attachment 338839 [details] [review]: pushed as commit acea894