After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773726 - /api should be replaced with /ovirt-engine/api
/api should be replaced with /ovirt-engine/api
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: ovirt
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-31 15:46 UTC by Yedidyah Bar David
Modified: 2016-11-25 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
virt-broker: Do not sanitize oVirt URI (1.40 KB, patch)
2016-11-23 11:53 UTC, Felipe Borges
none Details | Review
ovirt-broker: Do not sanitize oVirt URI (1.41 KB, patch)
2016-11-23 11:53 UTC, Felipe Borges
committed Details | Review
configure: Bump libgovirt minimum version (717 bytes, patch)
2016-11-25 14:36 UTC, Felipe Borges
none Details | Review
configure: Bump libgovirt minimum version (717 bytes, patch)
2016-11-25 16:40 UTC, Felipe Borges
committed Details | Review

Description Yedidyah Bar David 2016-10-31 15:46:28 UTC
Since oVirt 3.4, /ovirt-engine/api is preffered, and /api is
obsoleted [1].

Since 4.0, /api is removed [2].

Tried to patch [3], built on Fedora 24, but it still did not work, with:

(gnome-boxes:29697): libgovirt-WARNING **: Passing a full http:// or https:// URI to ovirt_proxy_new() is deprecated

(gnome-boxes:29697): libgovirt-WARNING **: Passing an URI ending in /api to ovirt_proxy_new() is deprecated

Not sure why. Perhaps some other places need to be patched.

[1] https://bugzilla.redhat.com/961677
[2] https://gerrit.ovirt.org/44420
[3] https://github.com/didib/gnome-boxes/commit/f846bfcb7a98b206c6e7341026c046cd1cb222fc
Comment 1 Felipe Borges 2016-11-23 11:53:11 UTC
Created attachment 340591 [details] [review]
virt-broker: Do not sanitize oVirt URI

Since libgovirt commit 086bd88, the proxy URI no longer needs to
have the "/api" path neither the https prefix. The sanitization
is now handled by libgovirt.
Comment 2 Felipe Borges 2016-11-23 11:53:38 UTC
Created attachment 340592 [details] [review]
ovirt-broker: Do not sanitize oVirt URI

Since libgovirt commit 086bd88, the proxy URI no longer needs to
have the "/api" path neither the https prefix. The sanitization
is now handled by libgovirt.
Comment 3 Zeeshan Ali 2016-11-23 20:21:48 UTC
(In reply to Felipe Borges from comment #1)
> Created attachment 340591 [details] [review] [review]
> virt-broker: Do not sanitize oVirt URI
> 
> Since libgovirt commit 086bd88, the proxy URI no longer needs to
> have the "/api" path neither the https prefix. The sanitization
> is now handled by libgovirt.

Cool. Please update the libgovirt required version first, in a separate patch.
Comment 4 Felipe Borges 2016-11-25 14:36:11 UTC
Created attachment 340759 [details] [review]
configure: Bump libgovirt minimum version
Comment 5 Felipe Borges 2016-11-25 16:40:51 UTC
Created attachment 340771 [details] [review]
configure: Bump libgovirt minimum version
Comment 6 Zeeshan Ali 2016-11-25 17:57:55 UTC
Attachment 340592 [details] pushed as 95ee507 - ovirt-broker: Do not sanitize oVirt URI