GNOME Bugzilla – Bug 773674
meson: don't use subproject fallback for gst-validate if it won't work
Last modified: 2016-11-11 00:38:57 UTC
Created attachment 338776 [details] [review] meson: don't use subproject fallback for gst-validate if it won't work Otherwise it will fail.
Review of attachment 338776 [details] [review]: I do not really like that, it is becoming ugly to check for json-glib everywhere. I proposed adding meson support in json-glib(0), I believe it will get merge soon, meanwhile I could use my branch in a wrap, not sur what you think? (0) https://bugzilla.gnome.org/show_bug.cgi?id=773603
I don't know about having to check "everywhere" :) I think we want something like an 'allow_fallback' kwarg added to subproject() in meson. This patch is mostly about fixing gst-build breakage today. I know it's not very nice, but it's also not super-ugly. If a better solution comes up we can switch to using that. Alternatively we can also not build ges by default in gst-build.
Oh, sorry, I forgot to answer your question: I don't want us to use inofficial branches. I propose to apply this for the time being and when it's merged we switch over to that :)
Review of attachment 338776 [details] [review]: Also this should not be needed as gst-validate is optionnal so if subproject fails it should not fail the build, bug in mesón?
(In reply to Tim-Philipp Müller from comment #3) > Oh, sorry, I forgot to answer your question: I don't want us to use > inofficial branches. I propose to apply this for the time being and when > it's merged we switch over to that :) Fait enough.
> Also this should not be needed as gst-validate is optional so if > subproject fails it should not fail the build, bug in mesón? Not sure I follow. gst-validate as external dependency is optional, but the fallback ensures that if it's not found as external dependency a subproject() will be used. We will then hard-require the hard-dependencies of the subproject. This is what this patch addresses. I think Meson is working as intended in this case. (There is another bug concerning the libxml dependency checking which we'll have to work around, but it's not directly related to this as far as I can tell - https://github.com/mesonbuild/meson/issues/964).
I think I disagree that behaviour is correct as the the dpendency is explicitly marked as 'required : false' which should mean, fmpov, that in any case, no fallback avalaible, or fallback build failling, we should just keep going without that dep.
Review of attachment 338776 [details] [review]: Go ahead anyway we already started in that dirección and we should finish it.
Interesting. I'm not aware that it is supposed to work like that already, but there might be an argument for doing it like you say. Something for Meson devs.
Apparently this is supposed to work already, just not sure in which version: https://github.com/mesonbuild/meson/issues/975
OK, and I fixed it? :) It is in 0.35 so I am not sure why you opened that bug? :)
Because it was actually failing for me, but I'm not 100% sure now if it was with 0.34 or 0.35. So let's just close this.