After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 773649 - Save task if we changed its name (edit-pane)
Save task if we changed its name (edit-pane)
Status: RESOLVED FIXED
Product: gnome-todo
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-10-28 21:23 UTC by Victor Toso
Modified: 2016-11-01 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtd-task: fix subtask-removed doc (928 bytes, patch)
2016-10-28 21:24 UTC, Victor Toso 		committed Details | Review
edit-pane: save task if we edit its name (1.50 KB, patch)
2016-10-28 21:24 UTC, Victor Toso 		needs-work Details | Review

Description Victor Toso 2016-10-28 21:23:58 UTC 
yay o/

I'm not 100% sure but if we change the task name by navigating with <TAB> it
might not save as the task was not selected (not on edit-pane) ... not sure if
it really happens and if we care.
Comment 1 Victor Toso 2016-10-28 21:24:03 UTC 
Created attachment 338748 [details] [review]
gtd-task: fix subtask-removed doc

Signed-off-by: Victor Toso <victortoso@redhat.com>
Comment 2 Victor Toso 2016-10-28 21:24:09 UTC 
Created attachment 338749 [details] [review]
edit-pane: save task if we edit its name

If we select a task and edit its name, it should save the change.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Comment 3 Georges Basile Stavracas Neto 2016-10-28 23:25:14 UTC 
Review of attachment 338748 [details] [review]:

LGTM
Comment 4 Georges Basile Stavracas Neto 2016-10-28 23:26:09 UTC 
Review of attachment 338749 [details] [review]:

I think it'd be better if this code was put in GtdTaskRow.
Comment 5 Victor Toso 2016-10-29 12:24:40 UTC 
(In reply to Georges Basile Stavracas Neto from comment #4)
> Review of attachment 338749 [details] [review] [review]:
> 
> I think it'd be better if this code was put in GtdTaskRow.

Sure, I'll rework that.
Comment 6 Victor Toso 2016-10-29 20:38:37 UTC 
Comment on attachment 338748 [details] [review]
gtd-task: fix subtask-removed doc

Attachment 338748 [details] pushed as 10cf162 - gtd-task: fix subtask-removed doc
Comment 7 Victor Toso 2016-11-01 13:51:14 UTC 
Fixed upstream ~ likely by
https://git.gnome.org/browse/gnome-todo/commit/?id=4beb1e61a3231bfde4d978193248a5f3a8fdb8ce

Thanks!